-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for Kubernetes 1.12+ #3180
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: outcoldman If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
@minikube-bot OK to test |
@dlorenc is it related to my change? or just a test issue? I can change back ‘1.10’ as default, that probably should keep all the test green. |
@dlorenc I switched it back to |
tests are still failing, is it me or some configuration issues? |
@outcoldman , please see #3132 (comment) comment. I am not sure if that is relevant. |
@tamalsaha hard to tell, considering that I am using by default the same version as before, not sure how that can affect tests |
@minikube-bot OK to test |
bootstrapTokens: | ||
- groups: | ||
- system:bootstrappers:kubeadm:default-node-token | ||
token: 599s02.8i3w2yyyay8t0onm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How was this value arrived at?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have used kubeadm config upgrade
, cleared all the default values, just by accident left this one. I will remove it.
FYI: The remaining flakes appear to be due to #3163 - now resolved. There are other flakes, of course. @minikube-bot OK to test |
Please update Docker to v18.06.1 for supporting |
@tstromberg update PR description and removed token generated by |
Fixes #3164
Support for k8s 1.12+, also keeping support for old versions of k8s.
See this comment for the list of incompatibilities with 1.12 #3164 (comment)
It uses
kubeadm.k8s.io/v1alpha1
for kubeadm. Kubernetes 1.12 does not support versionv1alpha1
. Onlyv1alpha2
. The recommended version isv1alpha3
. I usedkubeadm config upgrade ...
to convert v1alpha1 to v1alpha1 and to v1alpha3.This addon is not available
/usr/bin/kubeadm alpha phase addon kube-dns
, I guess it should usecoredns
instead (change in kubeadm to changekube-dns
tocoredns
)The argument
cadvisor-port
is not available in k8s-1.12