-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config parameter for the cri socket path #3154
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: afbjorklund If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks like some failing tests in travis: kubeadm_test.go:245: actual config does not match expected. actual: |
Not sure if cri-socket should be a top-level citizen, but it was that way in
Will look at the test suites. |
It seems that it inserted a newline, so I suppose the template needs to be modified slightly... FAIL k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm 0.154s |
ok k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm 0.141s |
Note that |
@afbjorklund this PR needs rebase. |
c9ad4e3
to
44b7ff5
Compare
Also fix the syntax for CRI-O, adding unix://
44b7ff5
to
5a3241f
Compare
Closes #3153