Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to enable docker, to please kubeadm #2406

Merged
merged 1 commit into from
Feb 5, 2018

Conversation

afbjorklund
Copy link
Collaborator

The kubeadm preflight looks if the docker service is enabled,
rather than checking the docker socket... So make it happy.

The kubeadm preflight looks if the docker service is enabled,
rather than checking the docker socket... So make it happy.
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 8, 2018
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@dlorenc
Copy link
Contributor

dlorenc commented Jan 8, 2018

@minikube-bot add to whitelist

@afbjorklund
Copy link
Collaborator Author

Presumably the docker.service was removed/disabled on purpose (56e250e), but I don't think that /etc/systemd is being persisted anyway (so this enable should only last as long as the VM runs) ?

@dlorenc
Copy link
Contributor

dlorenc commented Jan 30, 2018

@minikube-bot test this please

@dlorenc dlorenc merged commit 0e674ef into kubernetes:master Feb 5, 2018
@afbjorklund afbjorklund deleted the enable-docker branch February 11, 2018 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants