Fix darwin native build #1692
Merged
Fix darwin native build #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cross build container we use for darwin needs two extra environment variables to invoke specific C and CPP compilers. These aren't needed and won't work natively on darwin, so only pass them in for docker builds.
k8s-ci-robot
added
the
cncf-cla: yes
dlorenc
approved these changes
Jul 13, 2017
Codecov Report
@@ Coverage Diff @@
## master #1692 +/- ##
=========================================
- Coverage 38.77% 38.7% -0.08%
=========================================
Files 51 51
Lines 2664 2664
=========================================
- Hits 1033 1031 -2
- Misses 1452 1453 +1
- Partials 179 180 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cross build container we use for darwin needs two extra environment
variables to invoke specific C and C++ compilers. These aren't needed
and won't work natively on darwin, so only pass them in for docker
builds.