Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kernel configs for supporting vsocks #1686

Merged
merged 1 commit into from
Jul 12, 2017
Merged

Add kernel configs for supporting vsocks #1686

merged 1 commit into from
Jul 12, 2017

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Jul 12, 2017

cc @dlorenc we might eventually need this?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 12, 2017
@r2d4 r2d4 changed the title Add kernel configs for support vsocks Add kernel configs for supporting vsocks Jul 12, 2017
aaron-prindle
aaron-prindle approved these changes Jul 12, 2017
View reviewed changes
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Not really sure the use for this as it is linux only and running containers natively seems to be the best solution there.

Edit: Oh nice vsock works on OSX too.

dlorenc
dlorenc reviewed Jul 12, 2017
View reviewed changes
Copy link
Contributor

@dlorenc dlorenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need CONFIG_VHOST_VSOCK=y

@r2d4
Copy link
Contributor Author

r2d4 commented Jul 12, 2017

Added the CONFIG_VHOST_VSOCK option too. It magically appeared after I had enabled the networking vsock module.

@codecov-io
Copy link

Codecov Report

Merging #1686 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1686      +/-   ##
==========================================
+ Coverage   38.67%   38.71%   +0.03%     
==========================================
  Files          51       51              
  Lines        2671     2671              
==========================================
+ Hits         1033     1034       +1     
+ Misses       1457     1456       -1     
  Partials      181      181
Impacted Files Coverage Δ
pkg/util/kubeconfig/config.go 51.4% <0%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fa8b92...c0e1559. Read the comment docs.

@r2d4
Copy link
Contributor Author

r2d4 commented Jul 12, 2017

@minikube-bot retest this please

dlorenc
dlorenc approved these changes Jul 12, 2017
View reviewed changes
Copy link
Contributor

@dlorenc dlorenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you build a new ISO and bump it in the Makefile once this goes in?

@r2d4 r2d4 merged commit 6f5972f into kubernetes:master Jul 12, 2017
@r2d4 r2d4 deleted the vsock branch July 12, 2017 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-prindle aaron-prindle aaron-prindle approved these changes

@dlorenc dlorenc dlorenc approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@r2d4 @codecov-io @dlorenc @aaron-prindle @k8s-ci-robot