Addon: add headlamp #14315

yolossn · 2022-06-10T11:58:44Z

Headlamp is an opensource easy-to-use and extensible Kubernetes web UI.
Headlamp supports the following features.

Vendor independent / generic Kubernetes UI
Works in-cluster, or locally as a desktop app
Multi-cluster
Extensible through plugins
UI controls reflecting user roles (no deletion/update if not allowed)
Clean & modern UI
Cancellable creation/update/deletion operations
Logs, exec, and resource editor with documentation
Read-write / interactive (actions based on permissions)

linux-foundation-easycla · 2022-06-10T11:58:48Z

The committers listed above are authorized under a signed CLA.

✅ login: yolossn / name: S Santhosh Nagaraj (1fdd8db)

k8s-ci-robot · 2022-06-10T11:58:52Z

Welcome @yolossn!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-06-10T11:58:52Z

Hi @yolossn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2022-06-10T11:59:03Z

Can one of the admins verify this patch?

spowelljr

Thanks for the PR, it looks good, but could you add an integration test that ensures the pods you're expecting come up. This will help us detect if the addon starts failing with a Kubernetes update or anything else that could cause it to fail.

https://github.com/kubernetes/minikube/blob/master/test/integration/addons_test.go

site/content/en/docs/handbook/addons/headlamp.md

yolossn · 2022-06-13T10:51:47Z

Thanks for the PR, it looks good, but could you add an integration test that ensures the pods you're expecting come up. This will help us detect if the addon starts failing with a Kubernetes update or anything else that could cause it to fail.

https://github.com/kubernetes/minikube/blob/master/test/integration/addons_test.go

@spowelljr Added the integration test as suggested, Can you PTAL ?

test/integration/addons_test.go

spowelljr · 2022-06-14T18:21:54Z

/ok-to-test

minikube-pr-bot · 2022-06-14T19:46:05Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14315) |
+----------------+----------+---------------------+
| minikube start | 50.9s    | 50.1s               |
| enable ingress | 27.7s    | 28.1s               |
+----------------+----------+---------------------+

Times for minikube (PR 14315) start: 50.5s 50.5s 50.9s 49.8s 48.6s
Times for minikube start: 51.6s 50.0s 51.2s 50.4s 51.3s

Times for minikube ingress: 29.6s 25.2s 25.6s 29.1s 29.1s
Times for minikube (PR 14315) ingress: 28.6s 28.1s 28.6s 28.6s 26.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14315) |
+----------------+----------+---------------------+
| minikube start | 28.8s    | 24.9s               |
| enable ingress | 22.1s    | 21.5s               |
+----------------+----------+---------------------+

Times for minikube start: 46.3s 24.3s 23.9s 24.6s 24.8s
Times for minikube (PR 14315) start: 25.3s 24.6s 24.9s 25.2s 24.5s

Times for minikube (PR 14315) ingress: 21.4s 21.4s 21.4s 21.9s 21.4s
Times for minikube ingress: 22.4s 21.9s 21.9s 22.4s 21.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14315) |
+----------------+----------+---------------------+
| minikube start | 32.7s    | 30.6s               |
| enable ingress | 19.2s    | 22.4s               |
+----------------+----------+---------------------+

Times for minikube (PR 14315) start: 29.3s 32.6s 28.4s 28.9s 33.7s
Times for minikube start: 30.1s 33.7s 32.9s 34.7s 32.1s

Times for minikube (PR 14315) ingress: 30.9s 17.9s 22.4s 21.9s 18.9s
Times for minikube ingress: 22.4s 18.0s 18.9s 17.9s 18.9s

yolossn · 2022-06-15T11:46:10Z

Hey @spowelljr I looked into why some of the checks are failing and it doesn't seem to be related to the changes, Do you think a rerun will help in this case? Or is there something that I am missing?

spowelljr · 2022-06-15T18:27:40Z

Hi @yolossn, we have several flakey tests so we expect many to fail. We're having an issue with our Docker Linux CI right now, so once we get that fixed I'll rerun the tests.

spowelljr · 2022-06-15T20:56:51Z

Hi @yolossn, could you pull the latest master of minikube and then rebase your PR, that will pull in the CI fix and will rerun your tests, thanks

Signed-off-by: Santhosh Nagaraj S <[email protected]>

yolossn · 2022-06-16T06:46:02Z

Hi @yolossn, could you pull the latest master of minikube and then rebase your PR, that will pull in the CI fix and will rerun your tests, thanks

Done 👍🏽

minikube-pr-bot · 2022-06-16T13:44:35Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Hyper-V_Windows	TestNetworkPlugins/group/cilium/NetCatPod (gopogh)	0.00 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/false/Start (gopogh)	10.48 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/calico/Start (gopogh)	11.29 (chart)
Hyper-V_Windows	TestNetworkPlugins/group/custom-flannel/Start (gopogh)	12.90 (chart)
Docker_Windows	TestAddons/Setup (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/CertSync (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/CpCmd (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/DockerEnv/powershell (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/FileSync (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageBuild (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageListJson (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageListShort (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageListTable (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/Setup (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/MySQL (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/NodeLabels (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/SSHCmd (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/StatusCmd (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/UpdateContextCmd/no_changes (gopogh)	47.95 (chart)
Docker_Windows	TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh)	47.95 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

spowelljr · 2022-06-16T17:40:57Z

/retest-this-please

minikube-pr-bot · 2022-06-16T18:37:48Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14315) |
+----------------+----------+---------------------+
| minikube start | 50.8s    | 51.9s               |
| enable ingress | 28.5s    | 28.1s               |
+----------------+----------+---------------------+

Times for minikube start: 50.5s 51.2s 50.8s 50.9s 50.4s
Times for minikube (PR 14315) start: 51.3s 52.7s 51.5s 52.4s 51.5s

Times for minikube (PR 14315) ingress: 28.6s 28.6s 25.0s 29.2s 29.1s
Times for minikube ingress: 30.1s 28.1s 29.1s 26.1s 29.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14315) |
+----------------+----------+---------------------+
| minikube start | 25.0s    | 25.2s               |
| enable ingress | 22.9s    | 23.4s               |
+----------------+----------+---------------------+

Times for minikube start: 25.4s 24.9s 24.8s 24.7s 25.1s
Times for minikube (PR 14315) start: 24.5s 24.9s 25.9s 25.4s 25.2s

Times for minikube ingress: 22.9s 23.0s 23.0s 23.0s 22.4s
Times for minikube (PR 14315) ingress: 27.0s 22.9s 22.9s 22.4s 21.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14315) |
+----------------+----------+---------------------+
| minikube start | 33.5s    | 29.9s               |
| enable ingress | 22.5s    | 25.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 33.4s 22.4s 19.0s 18.9s 18.9s
Times for minikube (PR 14315) ingress: 18.9s 32.4s 22.0s 23.4s 32.4s

Times for minikube start: 41.1s 28.0s 33.6s 32.3s 32.6s
Times for minikube (PR 14315) start: 32.6s 28.9s 29.6s 29.3s 29.1s

yolossn · 2022-06-21T10:41:23Z

@spowelljr Gentle ping, Some tests still failed after rebase.

spowelljr · 2022-06-21T17:36:40Z

The tests look good to me @yolossn

k8s-ci-robot · 2022-06-21T17:37:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr, yolossn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 10, 2022

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 10, 2022

k8s-ci-robot requested review from prasadkatti and spowelljr June 10, 2022 11:59

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 10, 2022

spowelljr requested changes Jun 10, 2022

View reviewed changes

site/content/en/docs/handbook/addons/headlamp.md Outdated Show resolved Hide resolved

yolossn force-pushed the headlamp_addon branch from 1fdd8db to 4e8a65b Compare June 13, 2022 10:37

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2022

yolossn force-pushed the headlamp_addon branch 2 times, most recently from 77f32e2 to 5d93f30 Compare June 13, 2022 10:42

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2022

knrt10 suggested changes Jun 13, 2022

View reviewed changes

test/integration/addons_test.go Outdated Show resolved Hide resolved

yolossn force-pushed the headlamp_addon branch from 5d93f30 to 3b0bde4 Compare June 13, 2022 11:10

spowelljr requested changes Jun 13, 2022

View reviewed changes

test/integration/addons_test.go Show resolved Hide resolved

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 14, 2022

Addon: add headlamp

26afc8f

Signed-off-by: Santhosh Nagaraj S <[email protected]>

yolossn force-pushed the headlamp_addon branch from cca874b to 26afc8f Compare June 16, 2022 05:04

joaquimrocha mentioned this pull request Jun 17, 2022

Create minikube addon headlamp-k8s/headlamp#174

Closed

spowelljr approved these changes Jun 21, 2022

View reviewed changes

spowelljr merged commit e5754a2 into kubernetes:master Jun 21, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2022

knrt10 deleted the headlamp_addon branch June 21, 2022 18:18

alban mentioned this pull request Feb 9, 2023

[RFE] Add Inspektor Gadget as Minikube Addon inspektor-gadget/inspektor-gadget#1316

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Addon: add headlamp #14315

Addon: add headlamp #14315

yolossn commented Jun 10, 2022

linux-foundation-easycla bot commented Jun 10, 2022 •

edited

Loading

k8s-ci-robot commented Jun 10, 2022

k8s-ci-robot commented Jun 10, 2022

minikube-bot commented Jun 10, 2022

spowelljr left a comment

yolossn commented Jun 13, 2022

spowelljr commented Jun 14, 2022

minikube-pr-bot commented Jun 14, 2022

yolossn commented Jun 15, 2022

spowelljr commented Jun 15, 2022

spowelljr commented Jun 15, 2022

yolossn commented Jun 16, 2022

minikube-pr-bot commented Jun 16, 2022

spowelljr commented Jun 16, 2022

minikube-pr-bot commented Jun 16, 2022

yolossn commented Jun 21, 2022

spowelljr commented Jun 21, 2022

k8s-ci-robot commented Jun 21, 2022

Addon: add headlamp #14315

Addon: add headlamp #14315

Conversation

yolossn commented Jun 10, 2022

linux-foundation-easycla bot commented Jun 10, 2022 • edited Loading

k8s-ci-robot commented Jun 10, 2022

k8s-ci-robot commented Jun 10, 2022

minikube-bot commented Jun 10, 2022

spowelljr left a comment

Choose a reason for hiding this comment

yolossn commented Jun 13, 2022

spowelljr commented Jun 14, 2022

minikube-pr-bot commented Jun 14, 2022

yolossn commented Jun 15, 2022

spowelljr commented Jun 15, 2022

spowelljr commented Jun 15, 2022

yolossn commented Jun 16, 2022

minikube-pr-bot commented Jun 16, 2022

spowelljr commented Jun 16, 2022

minikube-pr-bot commented Jun 16, 2022

yolossn commented Jun 21, 2022

spowelljr commented Jun 21, 2022

k8s-ci-robot commented Jun 21, 2022

linux-foundation-easycla bot commented Jun 10, 2022 •

edited

Loading