Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kubernetes version default: v1.24.1 and latest: v1.24.1 #14197

Merged
merged 29 commits into from
Jun 22, 2022

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented May 19, 2022

Fixes #14128
Fixes #14298
Closes #14127

  • Bumped k8s versions
  • Updated kindnetd image
  • Fixed bug where was skipping starting the CRI service if --force-systemd passed
  • Fixed none driver CI machines not having cri-docker installed

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 19, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14197) |
+-------------------+----------+---------------------+
| ⚠️  minikube start | 52.4s    | 58.6s ⚠️             |
| enable ingress    | 28.5s    | 28.5s               |
+-------------------+----------+---------------------+

Times for minikube ingress: 25.2s 29.6s 29.2s 29.3s 29.1s
Times for minikube (PR 14197) ingress: 25.6s 28.1s 28.7s 30.2s 30.2s

Times for minikube start: 51.5s 52.5s 51.7s 52.6s 53.8s
Times for minikube (PR 14197) start: 63.7s 57.8s 57.3s 56.6s 57.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14197) |
+----------------+----------+---------------------+
| minikube start | 26.6s    | 29.1s               |
| enable ingress | 22.4s    | 23.0s               |
+----------------+----------+---------------------+

Times for minikube start: 31.8s 25.6s 25.2s 25.8s 24.6s
Times for minikube (PR 14197) start: 28.1s 28.3s 29.9s 29.1s 30.2s

Times for minikube ingress: 23.5s 20.9s 22.5s 22.5s 22.5s
Times for minikube (PR 14197) ingress: 22.4s 22.0s 23.1s 24.0s 23.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14197) |
+----------------+----------+---------------------+
| minikube start | 32.6s    | 28.9s               |
| enable ingress | 33.3s    | 29.3s               |
+----------------+----------+---------------------+

Times for minikube start: 34.9s 28.8s 28.8s 40.7s 29.8s
Times for minikube (PR 14197) start: 30.4s 25.5s 25.3s 37.2s 25.9s

Times for minikube ingress: 28.5s 31.5s 52.4s 32.0s 22.0s
Times for minikube (PR 14197) ingress: 27.4s 27.4s 27.0s 27.5s 37.0s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14197) |
+-------------------+----------+---------------------+
| ⚠️  minikube start | 51.8s    | 57.8s ⚠️             |
| enable ingress    | 27.8s    | 28.3s               |
+-------------------+----------+---------------------+

Times for minikube start: 52.0s 51.9s 51.9s 51.6s 51.6s
Times for minikube (PR 14197) start: 63.1s 55.8s 56.2s 57.6s 56.2s

Times for minikube ingress: 28.2s 28.6s 28.1s 25.1s 29.1s
Times for minikube (PR 14197) ingress: 29.1s 29.6s 28.6s 28.6s 25.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14197) |
+----------------+----------+---------------------+
| minikube start | 26.0s    | 27.9s               |
| enable ingress | 23.0s    | 22.1s               |
+----------------+----------+---------------------+

Times for minikube ingress: 23.9s 21.4s 24.0s 22.9s 22.9s
Times for minikube (PR 14197) ingress: 20.9s 23.4s 21.5s 22.5s 22.0s

Times for minikube start: 29.8s 25.2s 24.8s 24.7s 25.5s
Times for minikube (PR 14197) start: 28.9s 27.3s 28.1s 27.7s 27.6s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14197) |
+----------------+----------+---------------------+
| minikube start | 31.7s    | 28.7s               |
| enable ingress | 26.1s    | 27.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 31.9s 22.5s 21.9s 21.9s 32.4s
Times for minikube (PR 14197) ingress: 27.0s 27.4s 27.0s 27.4s 27.0s

Times for minikube start: 30.8s 28.7s 29.3s 40.4s 29.1s
Times for minikube (PR 14197) start: 45.3s 25.0s 24.2s 24.7s 24.4s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14197) |
+-------------------+----------+---------------------+
| ⚠️  minikube start | 51.6s    | 57.3s ⚠️             |
| enable ingress    | 28.7s    | 27.5s               |
+-------------------+----------+---------------------+

Times for minikube start: 52.5s 50.7s 52.3s 51.8s 50.8s
Times for minikube (PR 14197) start: 60.5s 54.9s 57.9s 55.9s 57.2s

Times for minikube ingress: 29.0s 26.5s 29.0s 29.6s 29.5s
Times for minikube (PR 14197) ingress: 29.0s 30.1s 23.7s 25.6s 29.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14197) |
+----------------+----------+---------------------+
| minikube start | 24.6s    | 28.4s               |
| enable ingress | 22.4s    | 22.2s               |
+----------------+----------+---------------------+

Times for minikube start: 23.7s 25.2s 24.9s 24.6s 24.4s
Times for minikube (PR 14197) start: 28.5s 29.2s 28.5s 28.1s 28.1s

Times for minikube ingress: 22.9s 23.9s 20.9s 20.9s 23.4s
Times for minikube (PR 14197) ingress: 20.9s 22.4s 21.9s 23.4s 22.4s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14197) |
+-------------------+----------+---------------------+
| minikube start    | 30.4s    | 29.3s               |
| ⚠️  enable ingress | 20.6s    | 27.3s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube ingress: 16.9s 22.4s 22.4s 18.9s 22.4s
Times for minikube (PR 14197) ingress: 27.4s 27.4s 27.4s 27.4s 26.9s

Times for minikube start: 35.0s 28.7s 27.8s 32.3s 28.4s
Times for minikube (PR 14197) start: 40.3s 35.0s 23.3s 24.2s 23.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Windows TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
KVM_Linux_containerd TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Cloud_Shell TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Windows TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/custom-weave/NetCatPod (gopogh) 0.00 (chart)
none_Linux TestAddons/Setup (gopogh) 0.00 (chart)
none_Linux TestCertExpiration (gopogh) 0.00 (chart)
none_Linux TestChangeNoneUser (gopogh) 0.00 (chart)
none_Linux TestErrorJSONOutput (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/DashboardCmd (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/MySQL (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/NodeLabels (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/PersistentVolumeClaim (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/ServiceCmd (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/ServiceCmdConnect (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/StatusCmd (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/UpdateContextCmd/no_changes (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/Version/components (gopogh) 0.00 (chart)
none_Linux TestFunctional/serial/ComponentHealth (gopogh) 0.00 (chart)
none_Linux TestFunctional/serial/ExtraConfig (gopogh) 0.00 (chart)
none_Linux TestFunctional/serial/KubeContext (gopogh) 0.00 (chart)
none_Linux TestFunctional/serial/KubectlGetPods (gopogh) 0.00 (chart)
none_Linux TestFunctional/serial/LogsCmd (gopogh) 0.00 (chart)
none_Linux TestFunctional/serial/LogsFileCmd (gopogh) 0.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Linux TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_macOS TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Windows TestDownloadOnly/v1.24.0/preload-exists (gopogh) n/a
Docker_Windows TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Hyperkit_macOS TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Hyper-V_Windows TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
KVM_Linux_containerd TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Cloud_Shell TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Linux TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/HairPin (gopogh) 0.00 (chart)
Docker_macOS TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Windows TestBinaryMirror (gopogh) 0.00 (chart)
Docker_Windows TestDownloadOnlyKic (gopogh) 0.00 (chart)
Docker_Windows TestDownloadOnly/v1.16.0/preload-exists (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/DryRun (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/parallel/InternationalLanguage (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/serial/CacheCmd/cache/add_remote (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/serial/CacheCmd/cache/delete (gopogh) 0.00 (chart)
Docker_Windows TestFunctional/serial/CacheCmd/cache/delete_k8s.gcr.io/pause (gopogh) 3.3 (chart)
Docker_Windows TestFunctional/serial/CacheCmd/cache/list (gopogh) 0.00 (chart)
Docker_Windows TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 0.00 (chart)
Docker_Windows TestKicCustomNetwork/use_default_bridge_network (gopogh) 0.00 (chart)
Docker_Windows TestNoKubernetes/serial/Stop (gopogh) 0.00 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
Hyperkit_macOS TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/bridge/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/calico/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/enable-default-cni/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/flannel/HairPin (gopogh) 0.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14197) |
+-------------------+----------+---------------------+
| ⚠️  minikube start | 51.6s    | 57.1s ⚠️             |
| enable ingress    | 28.5s    | 28.6s               |
+-------------------+----------+---------------------+

Times for minikube start: 53.2s 50.6s 51.5s 52.2s 50.4s
Times for minikube (PR 14197) start: 62.4s 56.8s 54.6s 56.9s 55.1s

Times for minikube ingress: 29.6s 29.1s 29.1s 29.1s 25.6s
Times for minikube (PR 14197) ingress: 28.1s 30.2s 29.1s 29.6s 26.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14197) |
+----------------+----------+---------------------+
| minikube start | 24.6s    | 28.0s               |
| enable ingress | 22.7s    | 23.0s               |
+----------------+----------+---------------------+

Times for minikube start: 24.2s 24.6s 24.0s 24.6s 25.3s
Times for minikube (PR 14197) start: 28.6s 28.0s 27.9s 27.6s 27.6s

Times for minikube ingress: 23.4s 22.9s 22.9s 22.5s 22.0s
Times for minikube (PR 14197) ingress: 23.0s 22.0s 22.5s 21.5s 25.9s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14197) |
+-------------------+----------+---------------------+
| minikube start    | 31.5s    | 34.6s               |
| ⚠️  enable ingress | 20.7s    | 27.2s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 30.8s 29.9s 33.6s 29.4s 33.6s
Times for minikube (PR 14197) start: 31.4s 34.8s 35.3s 35.6s 36.0s

Times for minikube (PR 14197) ingress: 27.4s 26.9s 27.5s 27.0s 27.5s
Times for minikube ingress: 22.5s 23.4s 17.9s 21.9s 18.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Linux TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Windows TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Hyperkit_macOS TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Hyper-V_Windows TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
KVM_Linux_containerd TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Cloud_Shell TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Linux TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 0.00 (chart)
Docker_Windows TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
Hyperkit_macOS TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Hyperkit_macOS TestMultiNode/serial/RestartMultiNode (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/bridge/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/calico/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/enable-default-cni/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/flannel/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/kindnet/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/kubenet/HairPin (gopogh) 0.00 (chart)
Hyper-V_Windows TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/AddNode (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/CopyFile (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/DeleteNode (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/DeployApp2Nodes (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/FreshStart2Nodes (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/ProfileList (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartMultiNode (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/StartAfterStop (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/StopMultiNode (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/StopNode (gopogh) 0.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Linux TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_macOS TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Windows TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Hyperkit_macOS TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Hyper-V_Windows TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
KVM_Linux_containerd TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Cloud_Shell TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Linux TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Linux TestDockerFlags (gopogh) 0.00 (chart)
Docker_macOS TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Hyperkit_macOS TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Hyperkit_macOS TestMultiNode/serial/RestartMultiNode (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/bridge/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/calico/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/enable-default-cni/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/flannel/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/kubenet/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestPause/serial/SecondStartNoReconfiguration (gopogh) 0.00 (chart)
Hyper-V_Windows TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/AddNode (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/CopyFile (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/DeleteNode (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/DeployApp2Nodes (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/FreshStart2Nodes (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/ProfileList (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartMultiNode (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/StartAfterStop (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/StopMultiNode (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/StopNode (gopogh) 0.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14197) |
+-------------------+----------+---------------------+
| ⚠️  minikube start | 51.5s    | 56.9s ⚠️             |
| enable ingress    | 26.1s    | 29.6s               |
+-------------------+----------+---------------------+

Times for minikube start: 53.2s 51.4s 50.5s 50.8s 51.6s
Times for minikube (PR 14197) start: 56.5s 56.7s 57.4s 57.0s 56.8s

Times for minikube ingress: 28.0s 25.5s 26.6s 25.0s 25.5s
Times for minikube (PR 14197) ingress: 32.5s 29.1s 28.1s 28.0s 30.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14197) |
+----------------+----------+---------------------+
| minikube start | 25.2s    | 27.9s               |
| enable ingress | 23.0s    | 22.1s               |
+----------------+----------+---------------------+

Times for minikube start: 30.0s 24.4s 23.7s 23.6s 24.3s
Times for minikube (PR 14197) start: 27.5s 28.6s 28.2s 28.2s 27.1s

Times for minikube ingress: 21.4s 22.4s 25.9s 23.0s 22.4s
Times for minikube (PR 14197) ingress: 22.0s 20.4s 23.9s 22.4s 21.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14197) |
+----------------+----------+---------------------+
| minikube start | 30.2s    | 30.9s               |
| enable ingress | 34.9s    | 27.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 14197) start: 25.2s 35.1s 24.0s 35.4s 34.9s
Times for minikube start: 34.0s 28.4s 31.4s 28.6s 28.4s

Times for minikube ingress: 17.9s 52.4s 18.9s 52.9s 32.4s
Times for minikube (PR 14197) ingress: 29.4s 26.9s 27.4s 26.9s 27.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Linux TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Windows TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Hyper-V_Windows TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
KVM_Linux_containerd TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Cloud_Shell TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Linux TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Linux TestDockerFlags (gopogh) 0.00 (chart)
Docker_Windows TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
Hyper-V_Windows TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/AddNode (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/CopyFile (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/DeleteNode (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/DeployApp2Nodes (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/FreshStart2Nodes (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/ProfileList (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartMultiNode (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/StartAfterStop (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/StopMultiNode (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/StopNode (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/ValidateNameConflict (gopogh) 0.00 (chart)
Hyper-V_Windows TestPause/serial/SecondStartNoReconfiguration (gopogh) 0.00 (chart)
Hyper-V_Windows TestStartStop/group/newest-cni/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
Hyper-V_Windows TestStartStop/group/newest-cni/serial/FirstStart (gopogh) 0.00 (chart)
Hyper-V_Windows TestStartStop/group/newest-cni/serial/SecondStart (gopogh) 0.00 (chart)
Hyper-V_Windows TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
KVM_Linux_containerd TestNetworkPlugins/group/custom-weave/NetCatPod (gopogh) 0.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 1.09 (chart)
Hyper-V_Windows TestStartStop/group/newest-cni/serial/Pause (gopogh) 1.09 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14197) |
+----------------+----------+---------------------+
| minikube start | 52.6s    | 57.6s               |
| enable ingress | 29.2s    | 29.3s               |
+----------------+----------+---------------------+

Times for minikube (PR 14197) start: 56.7s 55.6s 60.4s 60.7s 54.6s
Times for minikube start: 52.4s 52.5s 52.4s 53.4s 52.4s

Times for minikube ingress: 28.6s 29.7s 30.2s 29.1s 28.6s
Times for minikube (PR 14197) ingress: 29.1s 29.6s 30.2s 29.2s 28.6s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube (PR 14197): timing cmd: [/home/jenkins/.minikube/minikube-binaries/14197/minikube start --driver=docker --container-runtime=docker]: waiting for minikube: exit status 90
docker driver with containerd runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube start --driver=docker --container-runtime=containerd]: waiting for minikube: exit status 90

@spowelljr spowelljr changed the title Bump Kubernetes version default: v1.24.0 and latest: v1.24.1-rc.0 WIP: Bump Kubernetes version default: v1.24.0 and latest: v1.24.1-rc.0 May 27, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2022
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Linux TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_macOS TestDownloadOnly/v1.24.0/preload-exists (gopogh) n/a
Docker_macOS TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_macOS TestFunctional/parallel/ServiceCmdConnect (gopogh) n/a
Docker_Windows TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Hyperkit_macOS TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Hyperkit_macOS TestNetworkPlugins/group/custom-flannel/HairPin (gopogh) n/a
Hyper-V_Windows TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Hyper-V_Windows TestNetworkPlugins/group/custom-flannel/Start (gopogh) n/a
KVM_Linux_containerd TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Cloud_Shell TestAddons/Setup (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestFunctional/parallel/CertSync (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestFunctional/parallel/UpdateContextCmd/no_changes (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestFunctional/serial/AuditLog (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestFunctional/serial/CacheCmd/cache/cache_reload (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestFunctional/serial/CacheCmd/cache/verify_cache_inside_node (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestFunctional/serial/KubeContext (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestFunctional/serial/KubectlGetPods (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestFunctional/serial/MinikubeKubectlCmd (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestFunctional/serial/MinikubeKubectlCmdDirectly (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestFunctional/serial/SoftStart (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestFunctional/serial/StartWithProxy (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/DeployApp (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/Pause (gopogh) 0.00 (chart)
Docker_Cloud_Shell TestStartStop/group/cloud-shell/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
Docker_Linux_containerd TestKicCustomNetwork/create_custom_network (gopogh) 0.00 (chart)
Docker_Linux_containerd TestKicCustomNetwork/use_default_bridge_network (gopogh) 0.00 (chart)
Docker_Linux_containerd TestKicCustomSubnet (gopogh) 0.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh
Copy link
Member

medyagh commented May 29, 2022

Any luck with this pr?

@spowelljr
Copy link
Member Author

Any luck with this pr?

Some progress, none driver is passing minus metrics-server which is failing on all environments. KVM also has low failure rates. Once we solve the cri-dockerd in the kicbase image more tests should pass as well.

@medyagh
Copy link
Member

medyagh commented May 31, 2022

Any luck with this pr?

Some progress, none driver is passing minus metrics-server which is failing on all environments. KVM also has low failure rates. Once we solve the cri-dockerd in the kicbase image more tests should pass as well.

Excellent, once we solve these problems this should unblock us for a stable release

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14197) |
+-------------------+----------+---------------------+
| ⚠️  minikube start | 51.9s    | 57.4s ⚠️             |
| enable ingress    | 27.1s    | 28.3s               |
+-------------------+----------+---------------------+

Times for minikube start: 52.3s 53.3s 53.0s 50.4s 50.4s
Times for minikube (PR 14197) start: 58.4s 57.4s 56.8s 56.8s 57.7s

Times for minikube ingress: 25.2s 28.1s 24.6s 29.1s 28.6s
Times for minikube (PR 14197) ingress: 29.7s 26.2s 28.6s 28.6s 28.7s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Linux TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_macOS TestDownloadOnly/v1.24.0/preload-exists (gopogh) n/a
Docker_macOS TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Windows TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Hyperkit_macOS TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Hyper-V_Windows TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
KVM_Linux_containerd TestDownloadOnly/v1.24.1-rc.0/cached-images (gopogh) n/a
Docker_Cloud_Shell TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Linux TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Windows TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/EnableAddonWhileActive (gopogh) 0.00 (chart)
Hyperkit_macOS TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/bridge/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/calico/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/custom-flannel/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/enable-default-cni/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/flannel/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/kindnet/HairPin (gopogh) 0.00 (chart)
Hyperkit_macOS TestNetworkPlugins/group/kubenet/HairPin (gopogh) 0.00 (chart)
Hyper-V_Windows TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/AddNode (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/CopyFile (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/DeleteNode (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/DeployApp2Nodes (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/FreshStart2Nodes (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/ProfileList (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartMultiNode (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/StartAfterStop (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/StopMultiNode (gopogh) 0.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr
Copy link
Member Author

ok-to-build-iso

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14197) |
+-------------------+----------+---------------------+
| ⚠️  minikube start | 50.5s    | 56.2s ⚠️             |
| enable ingress    | 28.2s    | 29.5s               |
+-------------------+----------+---------------------+

Times for minikube (PR 14197) start: 56.6s 55.8s 56.4s 56.3s 55.6s
Times for minikube start: 49.1s 50.2s 50.9s 50.5s 51.8s

Times for minikube ingress: 26.6s 29.1s 30.5s 29.1s 25.6s
Times for minikube (PR 14197) ingress: 29.6s 29.6s 30.1s 28.6s 29.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14197) |
+----------------+----------+---------------------+
| minikube start | 24.5s    | 28.3s               |
| enable ingress | 22.4s    | 22.5s               |
+----------------+----------+---------------------+

Times for minikube start: 25.0s 24.1s 24.1s 25.1s 24.2s
Times for minikube (PR 14197) start: 27.9s 28.3s 28.3s 28.6s 28.7s

Times for minikube ingress: 21.9s 23.9s 22.9s 22.5s 20.9s
Times for minikube (PR 14197) ingress: 22.9s 21.9s 21.9s 21.9s 23.9s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14197) |
+-------------------+----------+---------------------+
| minikube start    | 31.8s    | 28.4s               |
| ⚠️  enable ingress | 21.5s    | 31.6s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube (PR 14197) start: 23.4s 35.0s 35.5s 23.8s 24.3s
Times for minikube start: 28.6s 32.6s 28.4s 39.8s 29.7s

Times for minikube ingress: 22.4s 18.9s 21.9s 22.5s 21.9s
Times for minikube (PR 14197) ingress: 37.4s 27.4s 38.4s 27.4s 27.4s

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14197) |
+-------------------+----------+---------------------+
| ⚠️  minikube start | 50.5s    | 57.2s ⚠️             |
| enable ingress    | 29.4s    | 27.5s               |
+-------------------+----------+---------------------+

Times for minikube start: 50.9s 50.1s 50.1s 51.5s 50.0s
Times for minikube (PR 14197) start: 56.5s 58.6s 56.5s 57.0s 57.1s

Times for minikube ingress: 30.6s 29.5s 28.5s 29.1s 29.5s
Times for minikube (PR 14197) ingress: 29.1s 28.6s 25.6s 29.1s 25.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14197) |
+----------------+----------+---------------------+
| minikube start | 24.2s    | 27.4s               |
| enable ingress | 21.8s    | 22.8s               |
+----------------+----------+---------------------+

Times for minikube start: 24.4s 23.5s 24.3s 24.1s 25.1s
Times for minikube (PR 14197) start: 27.4s 26.6s 28.4s 26.8s 27.7s

Times for minikube ingress: 20.9s 22.9s 22.4s 20.9s 21.9s
Times for minikube (PR 14197) ingress: 21.9s 22.4s 22.9s 23.4s 23.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14197) |
+----------------+----------+---------------------+
| minikube start | 35.8s    | 30.0s               |
| enable ingress | 25.5s    | 27.4s               |
+----------------+----------+---------------------+

Times for minikube (PR 14197) start: 34.3s 24.0s 23.3s 34.3s 34.0s
Times for minikube start: 39.3s 28.3s 43.4s 39.7s 28.3s

Times for minikube ingress: 22.5s 32.4s 28.4s 21.9s 22.4s
Times for minikube (PR 14197) ingress: 27.4s 27.4s 27.4s 27.4s 27.4s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14197) |
+----------------+----------+---------------------+
| minikube start | 50.8s    | 55.1s               |
| enable ingress | 40.3s    | 27.5s               |
+----------------+----------+---------------------+

Times for minikube start: 50.8s 51.2s 51.7s 50.9s 49.4s
Times for minikube (PR 14197) start: 54.5s 55.6s 54.1s 55.4s 55.8s

Times for minikube ingress: 27.0s 29.5s 30.1s 85.6s 29.5s
Times for minikube (PR 14197) ingress: 30.1s 25.5s 29.6s 25.6s 26.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14197) |
+----------------+----------+---------------------+
| minikube start | 24.0s    | 27.7s               |
| enable ingress | 34.6s    | 22.7s               |
+----------------+----------+---------------------+

Times for minikube start: 23.4s 23.7s 24.2s 24.2s 24.6s
Times for minikube (PR 14197) start: 26.4s 28.8s 28.0s 27.1s 28.0s

Times for minikube ingress: 22.4s 22.9s 22.9s 82.9s 21.9s
Times for minikube (PR 14197) ingress: 22.4s 23.4s 22.9s 22.9s 21.9s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14197) |
+-------------------+----------+---------------------+
| minikube start    | 35.3s    | 30.5s               |
| ⚠️  enable ingress | 22.1s    | 27.3s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 39.9s 44.3s 28.1s 31.9s 32.4s
Times for minikube (PR 14197) start: 23.6s 35.1s 34.5s 23.6s 35.5s

Times for minikube ingress: 22.4s 17.9s 22.4s 18.9s 28.9s
Times for minikube (PR 14197) ingress: 27.4s 27.4s 27.4s 27.4s 26.9s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14197) |
+-------------------+----------+---------------------+
| ⚠️  minikube start | 50.9s    | 56.8s ⚠️             |
| enable ingress    | 28.5s    | 28.6s               |
+-------------------+----------+---------------------+

Times for minikube start: 50.1s 52.6s 50.7s 51.0s 50.1s
Times for minikube (PR 14197) start: 54.5s 57.4s 56.2s 58.0s 57.8s

Times for minikube ingress: 29.1s 28.5s 25.6s 30.1s 29.3s
Times for minikube (PR 14197) ingress: 29.6s 28.6s 30.1s 25.6s 29.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14197) |
+----------------+----------+---------------------+
| minikube start | 24.1s    | 28.1s               |
| enable ingress | 24.0s    | 23.7s               |
+----------------+----------+---------------------+

Times for minikube start: 23.3s 24.2s 24.3s 24.7s 24.1s
Times for minikube (PR 14197) start: 28.7s 27.9s 28.4s 28.9s 26.7s

Times for minikube ingress: 25.5s 22.9s 26.9s 21.4s 23.4s
Times for minikube (PR 14197) ingress: 23.4s 22.4s 26.4s 22.4s 24.0s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 14197) |
+-------------------+----------+---------------------+
| minikube start    | 30.6s    | 32.9s               |
| ⚠️  enable ingress | 21.3s    | 27.3s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 32.6s 29.3s 28.6s 33.2s 29.0s
Times for minikube (PR 14197) start: 35.3s 23.7s 35.1s 35.4s 35.2s

Times for minikube ingress: 20.9s 21.9s 22.4s 18.9s 22.4s
Times for minikube (PR 14197) ingress: 27.4s 26.9s 27.4s 27.4s 27.4s

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit ef79e3d into kubernetes:master Jun 22, 2022
@spowelljr spowelljr deleted the k8s1.24 branch June 22, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
6 participants