Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KIC rootless: drop fuse-overlayfs; bump kernel requirement to 5.11 #13828

Merged
merged 1 commit into from
Mar 25, 2022
Merged

KIC rootless: drop fuse-overlayfs; bump kernel requirement to 5.11 #13828

merged 1 commit into from
Mar 25, 2022

Conversation

AkihiroSuda
Copy link
Member

minikube 1.23 (PR #12359) added fuse-overlayfs snapshotter for rootless Docker driver, but got broken in minikube 1.25 (issue #13534).

We can drop fuse-overlayfs for kernel >= 5.11.

Fixes #13534

We may add back fuse-overlayfs later if there is a huge demand to support kernel < 5.11.
That will require packing preloadable tarballs for fuse-overlayfs snapshotter.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2022
@AkihiroSuda AkihiroSuda mentioned this pull request Mar 22, 2022
Closed
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 22, 2022
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@AkihiroSuda
KIC rootless: drop fuse-overlayfs; bump kernel requirement to 5.11
7204b1d 
minikube 1.23 (PR 12359) added fuse-overlayfs snapshotter for rootless Docker driver,
but got broken in minikube 1.25 (issue 13534).

We can drop fuse-overlayfs for kernel >= 5.11.

Fix issue 13534

We may add back fuse-overlayfs later if there is a huge demand to
support kernel < 5.11.
That will require packing preloadable tarballs for fuse-overlayfs
snapshotter.

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda force-pushed the drop-fuse-overlayfs branch from b49f304 to 7204b1d Compare March 22, 2022 09:08
@AkihiroSuda AkihiroSuda mentioned this pull request Mar 22, 2022
Merged
klaases
klaases approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@klaases klaases left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AkihiroSuda, klaases
To complete the pull request process, please assign spowelljr after the PR has been reviewed.
You can assign the PR to them by writing /assign @spowelljr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@klaases
Copy link
Contributor

klaases commented Mar 23, 2022

ok-to-build-image

@afbjorklund
Copy link
Collaborator

We may add back fuse-overlayfs later if there is a huge demand to support kernel < 5.11.

Normally minikube tries to support "LTS" releases, and most of those are using 5.10 (or 5.4)

@minikube-bot
Copy link
Collaborator

Hi @AkihiroSuda, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@AkihiroSuda
Copy link
Member Author

We may add back fuse-overlayfs later if there is a huge demand to support kernel < 5.11.

Normally minikube tries to support "LTS" releases, and most of those are using 5.10 (or 5.4)

Rootless minikube does not work on 20.04 LTS by default in the first place because they do not use cgroup v2.

Ubuntu 22.04 LTS is planned to be shipped with cgroup v2 by default and with kernel 5.15.

@medyagh
Copy link
Member

medyagh commented Mar 24, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 24, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13828) |
+----------------+----------+---------------------+
| minikube start | 52.8s    | 53.2s               |
| enable ingress | 27.3s    | 27.1s               |
+----------------+----------+---------------------+

Times for minikube ingress: 26.0s 25.5s 27.0s 28.5s 29.6s
Times for minikube (PR 13828) ingress: 25.0s 29.5s 29.6s 26.5s 25.1s

Times for minikube start: 54.1s 52.9s 52.7s 52.9s 51.6s
Times for minikube (PR 13828) start: 54.6s 52.3s 52.3s 54.8s 51.7s

docker driver with docker runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10
docker driver with containerd runtime
error collecting results for docker driver: timing run 0 with minikube: timing cmd: [out/minikube addons enable ingress]: waiting for minikube: exit status 10

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 0.00 (chart)
KVM_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 0.60 (chart)
Docker_Linux TestCertExpiration (gopogh) 0.63 (chart)
Hyper-V_Windows TestNetworkPlugins/group/enable-default-cni/NetCatPod (gopogh) 1.71 (chart)
KVM_Linux_containerd TestFunctional/parallel/MountCmd/specific-port (gopogh) 1.81 (chart)
Docker_Linux_containerd TestNoKubernetes/serial/StartNoArgs (gopogh) 7.46 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/auto/Start (gopogh) 8.62 (chart)
Docker_Linux_containerd TestAddons/parallel/Registry (gopogh) 12.10 (chart)
Hyper-V_Windows TestErrorSpam/setup (gopogh) 13.77 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/custom-weave/Start (gopogh) 13.91 (chart)
Hyper-V_Windows TestSkaffold (gopogh) 15.94 (chart)
Hyper-V_Windows TestNetworkPlugins/group/flannel/Start (gopogh) 19.57 (chart)
Docker_Linux_containerd TestPause/serial/Start (gopogh) 20.13 (chart)
Docker_Linux_containerd TestOffline (gopogh) 28.30 (chart)
Docker_Linux_containerd TestFunctional/parallel/DashboardCmd (gopogh) 31.45 (chart)
Docker_Linux_containerd TestFunctional/parallel/MountCmd/any-port (gopogh) 31.45 (chart)
Docker_Linux_containerd TestFunctional/parallel/MySQL (gopogh) 31.45 (chart)
Docker_Linux_containerd TestFunctional/parallel/PersistentVolumeClaim (gopogh) 31.45 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmd (gopogh) 31.45 (chart)
Docker_Linux_containerd TestFunctional/parallel/ServiceCmdConnect (gopogh) 31.45 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 31.45 (chart)
Docker_Linux_containerd TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh) 31.45 (chart)
Docker_Linux_containerd TestFunctional/serial/ExtraConfig (gopogh) 31.45 (chart)
Docker_Linux_containerd TestFunctional/serial/SoftStart (gopogh) 31.45 (chart)
Docker_Linux_containerd TestFunctional/serial/StartWithProxy (gopogh) 31.45 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeployApp2Nodes (gopogh) 31.45 (chart)
Docker_Linux_containerd TestMultiNode/serial/PingHostFrom2Pods (gopogh) 31.45 (chart)
Hyper-V_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 31.88 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 33.06 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 36.96 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 23841c4 into kubernetes:master Mar 25, 2022
@criztovyl criztovyl mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaases klaases klaases approved these changes

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

@spowelljr spowelljr Awaiting requested review from spowelljr

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minikube start fails with rootless docker (Linux Mint 20.2)
7 participants
@AkihiroSuda @minikube-bot @k8s-ci-robot @klaases @afbjorklund @medyagh @minikube-pr-bot