-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade libvirt to "8th gen" #13440
upgrade libvirt to "8th gen" #13440
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prezha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube ingress: 29.1s 29.0s 30.0s 25.6s 29.6s Times for minikube start: 51.8s 43.8s 44.6s 43.8s 43.4s docker driver with docker runtime
Times for minikube start: 42.0s 25.5s 25.6s 25.9s 26.3s Times for minikube ingress: 22.9s 21.9s 23.4s 22.9s 23.4s docker driver with containerd runtime
Times for minikube (PR 13440) start: 44.6s 46.0s 41.9s 44.7s 45.0s Times for minikube ingress: 22.9s 23.4s 19.4s 23.4s 23.4s |
I wonder if this test failure is related to this PR or not for
|
fixes: #9642
we've already upgraded from libvirt v3.9.0 to v7.4.0 (#13042)
recently, with v8, libvirt changed from github.com/libvirt/libvirt-go to libvirt.org/go/libvirt and this pr reflects that, which should, in turn, also ease future upgrades as well
my (light) local tests have shown no issues so far...
useful ref: libvirt API support matrix