Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add BR2_PACKAGE_LIBFUSE addresses #12426 #13000

Merged
merged 1 commit into from
Jan 4, 2022
Merged

add BR2_PACKAGE_LIBFUSE addresses #12426 #13000

merged 1 commit into from
Jan 4, 2022

Conversation

schwichtgit
Copy link
Contributor

Minikube 1.23+ does not provide the openvmtools anymore causing mounts to fail using the vmware driver (as tested with VMWare Fusion on MacOS).

As the openvmtools package (https://github.com/buildroot/buildroot/blob/2021.02.x/package/openvmtools/openvmtools.mk) requires libfuse to work, this PR adds BR2_PACKAGE_LIBFUSE to minikube_defconfig resulting into a minikube.iso with a functional openvmtools including the hgfs driver.

@k8s-ci-robot
Copy link
Contributor

Hi @schwichtgit. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@medyagh
Copy link
Member

medyagh commented Nov 22, 2021

CC: @spowelljr

@medyagh
Copy link
Member

medyagh commented Nov 22, 2021

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @schwichtgit, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@schwichtgit schwichtgit changed the title add BR2_PACKAGE_LIBFUSE to address issue12426 add BR2_PACKAGE_LIBFUSE Fixes #12426 Nov 23, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 23, 2021
@schwichtgit schwichtgit changed the title add BR2_PACKAGE_LIBFUSE Fixes #12426 add BR2_PACKAGE_LIBFUSE addresses #12426 Nov 23, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 23, 2021
@schwichtgit
Copy link
Contributor Author

Hello @medyagh I am not sure if this PR waits for an action on my side, please let me know what exactly is expected.

@schwichtgit
Copy link
Contributor Author

@spowelljr @medyagh bump ...
Anything I can do to progress this PR?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, schwichtgit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2021
@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 30, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13000) |
+----------------+----------+---------------------+
| minikube start | 44.5s    | 43.8s               |
| enable ingress | 28.9s    | 27.4s               |
+----------------+----------+---------------------+

Times for minikube (PR 13000) ingress: 30.1s 25.1s 26.1s 29.1s 26.6s
Times for minikube ingress: 30.6s 26.1s 29.0s 29.6s 29.1s

Times for minikube start: 45.0s 43.5s 44.4s 44.2s 45.6s
Times for minikube (PR 13000) start: 43.6s 45.0s 43.9s 43.6s 42.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13000) |
+----------------+----------+---------------------+
| minikube start | 26.0s    | 26.1s               |
| enable ingress | 22.6s    | 22.1s               |
+----------------+----------+---------------------+

Times for minikube start: 26.9s 26.4s 25.6s 25.9s 25.4s
Times for minikube (PR 13000) start: 26.0s 27.2s 25.9s 25.9s 25.3s

Times for minikube ingress: 22.0s 22.9s 22.4s 22.9s 23.0s
Times for minikube (PR 13000) ingress: 21.9s 21.4s 22.9s 20.9s 23.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13000) |
+----------------+----------+---------------------+
| minikube start | 39.2s    | 43.4s               |
| enable ingress | 28.6s    | 22.7s               |
+----------------+----------+---------------------+

Times for minikube start: 33.4s 40.9s 40.7s 40.8s 40.1s
Times for minikube (PR 13000) start: 45.0s 45.5s 41.0s 40.8s 44.7s

Times for minikube ingress: 49.9s 22.9s 23.5s 23.4s 23.4s
Times for minikube (PR 13000) ingress: 18.9s 18.9s 23.4s 23.4s 28.9s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux TestKVMDriverInstallOrUpdate (gopogh) 0.00 (chart)
Docker_macOS TestJSONOutput/pause/Command (gopogh) 5.38 (chart)
KVM_Linux TestRunningBinaryUpgrade (gopogh) 6.25 (chart)
KVM_Linux TestStartStop/group/no-preload/serial/DeployApp (gopogh) 6.25 (chart)
KVM_Linux TestStartStop/group/no-preload/serial/EnableAddonWhileActive (gopogh) 6.25 (chart)
KVM_Linux TestStartStop/group/no-preload/serial/FirstStart (gopogh) 6.25 (chart)
KVM_Linux TestGvisorAddon (gopogh) 6.94 (chart)
KVM_Linux TestNetworkPlugins/group/calico/Start (gopogh) 9.03 (chart)
Docker_Linux TestStartStop/group/embed-certs/serial/Pause (gopogh) 9.86 (chart)
Docker_macOS TestNetworkPlugins/group/false/DNS (gopogh) 14.85 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 16.28 (chart)
Docker_macOS TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 26.13 (chart)
Docker_macOS TestNetworkPlugins/group/custom-weave/Start (gopogh) 42.28 (chart)
Docker_macOS TestNetworkPlugins/group/calico/DNS (gopogh) 45.00 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 65.12 (chart)
Docker_macOS TestNetworkPlugins/group/kubenet/Start (gopogh) 65.85 (chart)
Docker_macOS TestNetworkPlugins/group/kindnet/Start (gopogh) 69.11 (chart)
Hyperkit_macOS TestAddons/Setup (gopogh) 72.80 (chart)
Hyperkit_macOS TestErrorSpam/setup (gopogh) 72.80 (chart)
Hyperkit_macOS TestFunctional/serial/AuditLog (gopogh) 72.80 (chart)
Hyperkit_macOS TestFunctional/serial/StartWithProxy (gopogh) 72.80 (chart)
Hyperkit_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 72.80 (chart)
Hyperkit_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 72.80 (chart)
Hyperkit_macOS TestJSONOutput/pause/Audit (gopogh) 72.80 (chart)
Hyperkit_macOS TestJSONOutput/pause/Command (gopogh) 72.80 (chart)
Hyperkit_macOS TestJSONOutput/start/Audit (gopogh) 72.80 (chart)
Hyperkit_macOS TestJSONOutput/start/Command (gopogh) 72.80 (chart)
Hyperkit_macOS TestJSONOutput/start/parallel/DistinctCurrentSteps (gopogh) 72.80 (chart)
Hyperkit_macOS TestJSONOutput/start/parallel/IncreasingCurrentSteps (gopogh) 72.80 (chart)
Hyperkit_macOS TestJSONOutput/unpause/Audit (gopogh) 72.80 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 9c81a86 into kubernetes:master Jan 4, 2022
@schwichtgit schwichtgit mentioned this pull request Jan 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund afbjorklund approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@schwichtgit @k8s-ci-robot @minikube-bot @medyagh @spowelljr @minikube-pr-bot @afbjorklund