`minikube version`: add `--components` flag to list all included software #11843

medyagh · 2021-06-30T21:05:16Z

Before this PR

$ minikube version
minikube version: v1.21.0
commit: 76d74191d82c47883dc7e1319ef7cebd3e00ee11

After this PR

default case

$ mk version 
minikube version: v1.21.0
commit: 5fb11319c4c102346501539fa70fce482d14a038-dirty

json

$ mk version --components --output=json  | jq
{
  "buildctl": "buildctl github.com/moby/buildkit v0.8.2 9065b18ba4633c75862befca8188de4338d9f94a",
  "commit": "4e232b694f4eeb7ddaf2ea5d55c8a6d7a78334c4",
  "containerd": "containerd containerd.io 1.4.6 d71fcd7d8303cbf684402823e425e9dd2e99285d",
  "crictl": "Version:  0.1.0\nRuntimeName:  docker\nRuntimeVersion:  20.10.7\nRuntimeApiVersion:  1.41.0",
  "crio": "Version:       1.20.3\nGitCommit:     50065140109e8dc4b8fd6dc5d2b587e5cb7ed79d\nGitTreeState:  clean\nBuildDate:     2021-06-03T20:25:45Z\nGoVersion:     go1.15.2\nCompiler:      gc\nPlatform:      linux/amd64\nLinkmode:      dynamic",
  "ctr": "Client:\n  Version:  1.4.6\n  Revision: d71fcd7d8303cbf684402823e425e9dd2e99285d\n  Go version: go1.13.15\n\nServer:\n  Version:  1.4.6\n  Revision: d71fcd7d8303cbf684402823e425e9dd2e99285d\n  UUID: 84897789-18d8-458b-8bb7-b98824e7e949",
  "docker": "20.10.7",
  "minikubeVersion": "v1.21.0",
  "podman": "Version:      3.1.2\nAPI Version:  3.1.2\nGo Version:   go1.15.2\nBuilt:        Thu Jan  1 00:00:00 1970\nOS/Arch:      linux/amd64",
  "runc": "runc version 1.0.0-rc95\ncommit: b9ee9c6314599f1b4a7f497e1f1f856fe433d3b7\nspec: 1.0.2-dev\ngo: go1.13.15\nlibseccomp: 2.5.1"
}

raw

$ mk version --components 
minikube version: v1.21.0
commit: 4e232b694f4eeb7ddaf2ea5d55c8a6d7a78334c4-dirty

runc:
runc version 1.0.0-rc95
commit: b9ee9c6314599f1b4a7f497e1f1f856fe433d3b7
spec: 1.0.2-dev
go: go1.13.15
libseccomp: 2.5.1

docker:
20.10.7

containerd:
containerd containerd.io 1.4.6 d71fcd7d8303cbf684402823e425e9dd2e99285d

crio:
Version:       1.20.3
GitCommit:     50065140109e8dc4b8fd6dc5d2b587e5cb7ed79d
GitTreeState:  clean
BuildDate:     2021-06-03T20:25:45Z
GoVersion:     go1.15.2
Compiler:      gc
Platform:      linux/amd64
Linkmode:      dynamic

ctr:
Client:
  Version:  1.4.6
  Revision: d71fcd7d8303cbf684402823e425e9dd2e99285d
  Go version: go1.13.15

Server:
  Version:  1.4.6
  Revision: d71fcd7d8303cbf684402823e425e9dd2e99285d
  UUID: 84897789-18d8-458b-8bb7-b98824e7e949

podman:
Version:      3.1.2
API Version:  3.1.2
Go Version:   go1.15.2
Built:        Thu Jan  1 00:00:00 1970
OS/Arch:      linux/amd64

crictl:
Version:  0.1.0
RuntimeName:  docker
RuntimeVersion:  20.10.7
RuntimeApiVersion:  1.41.0

buildctl:
buildctl github.com/moby/buildkit v0.8.2 9065b18ba4633c75862befca8188de4338d9f94a
22:15:01 medya/workspace/minikube

yaml

mk version --components -o=yaml
buildctl: buildctl github.com/moby/buildkit v0.8.2 9065b18ba4633c75862befca8188de4338d9f94a
commit: 4e232b694f4eeb7ddaf2ea5d55c8a6d7a78334c4
containerd: containerd containerd.io 1.4.6 d71fcd7d8303cbf684402823e425e9dd2e99285d
crictl: |-
  Version:  0.1.0
  RuntimeName:  docker
  RuntimeVersion:  20.10.7
  RuntimeApiVersion:  1.41.0
crio: |-
  Version:       1.20.3
  GitCommit:     50065140109e8dc4b8fd6dc5d2b587e5cb7ed79d
  GitTreeState:  clean
  BuildDate:     2021-06-03T20:25:45Z
  GoVersion:     go1.15.2
  Compiler:      gc
  Platform:      linux/amd64
  Linkmode:      dynamic
ctr: |-
  Client:
    Version:  1.4.6
    Revision: d71fcd7d8303cbf684402823e425e9dd2e99285d
    Go version: go1.13.15

  Server:
    Version:  1.4.6
    Revision: d71fcd7d8303cbf684402823e425e9dd2e99285d
    UUID: 84897789-18d8-458b-8bb7-b98824e7e949
docker: 20.10.7
minikubeVersion: v1.21.0
podman: |-
  Version:      3.1.2
  API Version:  3.1.2
  Go Version:   go1.15.2
  Built:        Thu Jan  1 00:00:00 1970
  OS/Arch:      linux/amd64
runc: |-
  runc version 1.0.0-rc95
  commit: b9ee9c6314599f1b4a7f497e1f1f856fe433d3b7
  spec: 1.0.2-dev
  go: go1.13.15
  libseccomp: 2.5.1

medyagh · 2021-06-30T21:36:15Z

/ok-to-test

medyagh · 2021-06-30T23:46:30Z

/retest-this-please

minikube-pr-bot · 2021-07-01T00:46:39Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11843) |
+----------------+----------+---------------------+
| minikube start | 49.7s    | 47.0s               |
| enable ingress | 34.5s    | 35.6s               |
+----------------+----------+---------------------+

Times for minikube start: 51.9s 46.7s 50.9s 48.0s 50.7s
Times for minikube (PR 11843) start: 47.4s 46.6s 48.1s 47.0s 45.8s

Times for minikube ingress: 33.2s 34.3s 35.3s 33.8s 35.7s
Times for minikube (PR 11843) ingress: 36.7s 34.8s 36.3s 36.7s 33.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11843) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 21.6s               |
| enable ingress | 30.5s    | 30.4s               |
+----------------+----------+---------------------+

Times for minikube start: 22.0s 21.8s 22.7s 22.3s 22.5s
Times for minikube (PR 11843) start: 21.3s 20.8s 22.1s 22.1s 21.5s

Times for minikube ingress: 33.0s 29.5s 28.0s 32.0s 30.0s
Times for minikube (PR 11843) ingress: 33.0s 30.5s 30.5s 29.0s 29.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11843) |
+----------------+----------+---------------------+
| minikube start | 44.2s    | 44.4s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 43.5s 43.0s 48.3s 43.1s 43.1s
Times for minikube (PR 11843) start: 42.9s 46.7s 43.1s 46.4s 43.0s

test/integration/functional_test.go

ilya-zuyev

lgtm

k8s-ci-robot · 2021-07-01T20:03:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ilya-zuyev, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ilya-zuyev,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-pr-bot · 2021-07-01T21:21:05Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11843) |
+----------------+----------+---------------------+
| minikube start | 51.4s    | 49.2s               |
| enable ingress | 35.0s    | 34.0s               |
+----------------+----------+---------------------+

Times for minikube start: 50.2s 48.2s 55.7s 51.0s 51.7s
Times for minikube (PR 11843) start: 47.8s 51.8s 47.5s 51.0s 47.8s

Times for minikube ingress: 36.2s 36.2s 33.4s 34.8s 34.3s
Times for minikube (PR 11843) ingress: 33.9s 33.9s 34.9s 33.8s 33.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11843) |
+----------------+----------+---------------------+
| minikube start | 25.4s    | 22.7s               |
| enable ingress | 29.7s    | 28.6s               |
+----------------+----------+---------------------+

Times for minikube start: 35.8s 22.8s 21.9s 22.9s 23.5s
Times for minikube (PR 11843) start: 23.5s 23.1s 21.7s 22.2s 23.1s

Times for minikube ingress: 31.5s 29.5s 29.5s 30.0s 28.0s
Times for minikube (PR 11843) ingress: 27.5s 26.5s 29.0s 27.0s 33.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11843) |
+----------------+----------+---------------------+
| minikube start | 46.1s    | 40.2s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 45.3s 46.4s 47.7s 43.5s 47.7s
Times for minikube (PR 11843) start: 30.5s 31.4s 47.8s 46.9s 44.1s

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 30, 2021

k8s-ci-robot requested review from ilya-zuyev and prasadkatti June 30, 2021 21:05

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 30, 2021

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 30, 2021

medyagh changed the title ~~add --components flag for version command~~ add --components flag for version command Jun 30, 2021

medyagh changed the title ~~add --components flag for version command~~ minikube version: add --components flag to list all included software Jun 30, 2021

ilya-zuyev reviewed Jul 1, 2021

View reviewed changes

test/integration/functional_test.go Outdated Show resolved Hide resolved

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2021

medyagh added 5 commits July 1, 2021 15:21

add --components flag for verion command

f35d99a

fix boilerplate

61e06d7

semver

f51a5c1

check all components

4b17f54

resolve conflict

b5cf45a

medyagh force-pushed the ver_components branch from e5c2004 to b5cf45a Compare July 1, 2021 19:24

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2021

medyagh requested a review from ilya-zuyev July 1, 2021 19:55

ilya-zuyev approved these changes Jul 1, 2021

View reviewed changes

medyagh merged commit f83a69e into kubernetes:master Jul 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`minikube version`: add `--components` flag to list all included software #11843

`minikube version`: add `--components` flag to list all included software #11843

medyagh commented Jun 30, 2021 •

edited

Loading

medyagh commented Jun 30, 2021

medyagh commented Jun 30, 2021

minikube-pr-bot commented Jul 1, 2021

ilya-zuyev left a comment

k8s-ci-robot commented Jul 1, 2021

minikube-pr-bot commented Jul 1, 2021

minikube version: add --components flag to list all included software #11843

minikube version: add --components flag to list all included software #11843

Conversation

medyagh commented Jun 30, 2021 • edited Loading

Before this PR

After this PR

default case

json

raw

yaml

medyagh commented Jun 30, 2021

medyagh commented Jun 30, 2021

minikube-pr-bot commented Jul 1, 2021

ilya-zuyev left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 1, 2021

minikube-pr-bot commented Jul 1, 2021

`minikube version`: add `--components` flag to list all included software #11843

`minikube version`: add `--components` flag to list all included software #11843

medyagh commented Jun 30, 2021 •

edited

Loading