-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISO: Upgrade podman to 3.1.2 #11727
ISO: Upgrade podman to 3.1.2 #11727
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ok-to-build-iso |
This comment has been minimized.
This comment has been minimized.
f6fb5d7
to
11b2df4
Compare
ok-to-build-iso |
This comment has been minimized.
This comment has been minimized.
As stated above, this requires the OS to be updated first |
11b2df4
to
c8971d8
Compare
ok-to-build-iso |
Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
31df595
to
c8971d8
Compare
c8971d8
to
ab49c58
Compare
@afbjorklund Based on #11706 (comment), is this PR something we still want to pursue? And if so, does anything else still have to be done? #11727 (comment)? |
Well, there is a 3.4.0 now. They say it will be stable. Except of course that I think we could go for 3.3.1, but it is already EOL and all fixes go in 3.4 - except for the ones that will go into 4.0 instead Perhaps 3.0.1 is a conservative pick ? It's used in RHEL 7 and other dinosaurs |
I'm happy to go with whatever version you think is best, I can create a PR to update to your preferred version if you don't have the time to do so. |
So is v3.1.2 the final choice or is it a reference to then try and compare with v3.4.2? |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
We can bump it further, I don't think the version was ever the problem with the ISO build.
Usually the versions that RHEL and Debian choose, are better choices for long term
EDIT: Forgot that go was patched to 1.17 already Can try upgrading it from v3.1.2 to v3.4.2 later on |
kvm2 driver with docker runtime
Times for minikube start: 46.0s 46.0s 46.7s 45.5s 46.3s Times for minikube ingress: 32.2s 31.7s 30.8s 30.8s 31.7s docker driver with docker runtime
Times for minikube (PR 11727) start: 20.2s 20.8s 19.9s 20.1s 20.4s Times for minikube ingress: 26.4s 25.9s 26.9s 25.9s 27.4s docker driver with containerd runtime
Times for minikube ingress: 32.9s 32.4s 32.4s 17.9s 17.4s Times for minikube start: 25.3s 42.2s 40.8s 40.8s 41.1s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
20a7509
to
5493af0
Compare
kvm2 driver with docker runtime
Times for minikube start: 45.7s 45.0s 44.5s 44.3s 46.2s Times for minikube (PR 11727) ingress: 28.6s 29.1s 26.1s 29.1s 29.6s docker driver with docker runtime
Times for minikube start: 27.1s 26.5s 26.6s 25.8s 25.8s Times for minikube ingress: 22.4s 22.9s 21.9s 21.9s 22.4s docker driver with containerd runtime
Times for minikube start: 30.9s 41.7s 41.2s 41.8s 45.7s Times for minikube ingress: 33.4s 33.4s 33.4s 32.9s 58.9s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
Did you have success? v3,4,4 is out and v3.4.3 fixes two CVEs. |
Nope. Not sure how much the podman machine CVE affects minikube, it mostly affects the host Podman ? Nor if anyone uses OCI images, minikube normally uses Docker images. |
Anyway, ISO build failures were unrelated to podman |
Nice to hear. Any chance to rebase on top of latest stable release? I don't know what is your Git workflow, but if something is polluting the tests, it would be better to separate concerns. |
It builds OK here The monolithic build is a stability issue for CI, but also the packages can have their own issues (currently KIC us failing on checksums) |
Quite strange then, if the only change is the podman version and the reason for not building is unrelated to podman :S |
Oh, ok. So then there is no reason to choose one instead of another, isn't it? I mean, being up-to-date today means not being too out-of-date soon. |
Getting some help now, so hopefully will be back on track soon. First we want to upgrade os version and build for arm64. But upgrading kernel and container runtimes is also on the wishlist, and long overdue due to the other upgrade issues... |
Let's do another PR, when this is possible. |
@afbjorklund I would be willing to help on this. Looking at comments and trying to understand what was the problem blocking the PR / tests. Is there a issue opened to track? |
Not really, it was a simple version upgrade... Should probably upgrade to something like 3.4.2, before the big 4.0.0 comes and deletes all the packages. For minikube purposes, the actual 3.x probably doesn't matter at all. And 3.0.1 is still "supported", for afaik.
Most requests are still for dockerd, some for containerd. |
There are legitimate use cases for more recent (better and less buggier) versions of Podman, such as https://github.com/devonfw-forge/podman-minikube (i.e. ditching Docker Desktop and even docker) |
Podman has its own built-in solution with CoreOS, but sure it could be useful for |
The idea is to "silently" introduce Kubernetes and let developers naturally use it just because they already have it. |
The plan is still to make both podman and nerdctl versions available, presumably using modern versions of each. Just have to get the ISO out of the current sad state. And |
I guess you were talking about Podman machine for MacOS, I was talking about Windows, in the cases where WSL2 is not feasible. Or does Podman machine offer an independent backend on Windows? Edit: not yet containers/podman#13006 |
Note: podman3 requires go to be updated first (new OS)
build flag -mod=vendor only valid when using modules
Closes #11706