Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO: Upgrade Docker, from 20.10.6 to 20.10.7 #11593

Closed
wants to merge 2 commits into from

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Jun 7, 2021

  • runc v1.0.0-rc95

  • containerd v1.4.6

This is for the ISO, I think that the KIC will do the upgrade automatically ?

The following packages will be upgraded:
  containerd.io docker-ce docker-ce-cli
3 upgraded, 0 newly installed, 0 to remove and 21 not upgraded.
Need to get 94.5 MB of archives.
After this operation, 324 kB of additional disk space will be used.
Get:1 https://download.docker.com/linux/ubuntu focal/stable amd64 containerd.io amd64 1.4.6-1 [28.3 MB]
Get:2 https://download.docker.com/linux/ubuntu focal/stable amd64 docker-ce-cli amd64 5:20.10.7~3-0~ubuntu-focal [41.4 MB]
Get:3 https://download.docker.com/linux/ubuntu focal/stable amd64 docker-ce amd64 5:20.10.7~3-0~ubuntu-focal [24.8 MB]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 7, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2021
@sharifelgamal
Copy link
Collaborator

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 7, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11593) |
+----------------+----------+---------------------+
| minikube start | 46.4s    | 46.5s               |
| enable ingress | 35.1s    | 35.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 34.2s 34.2s 35.7s 37.8s 33.8s
Times for minikube (PR 11593) ingress: 36.3s 33.3s 35.4s 35.7s 34.1s

Times for minikube (PR 11593) start: 46.5s 46.2s 48.1s 46.2s 45.4s
Times for minikube start: 46.3s 45.9s 47.1s 46.5s 46.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11593) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 21.9s               |
| enable ingress | 29.5s    | 30.3s               |
+----------------+----------+---------------------+

Times for minikube start: 22.7s 21.0s 22.9s 21.8s 22.1s
Times for minikube (PR 11593) start: 21.1s 21.6s 22.5s 21.9s 22.2s

Times for minikube ingress: 32.5s 29.0s 27.5s 27.0s 31.5s
Times for minikube (PR 11593) ingress: 30.5s 31.1s 32.5s 28.5s 29.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11593) |
+----------------+----------+---------------------+
| minikube start | 45.2s    | 46.3s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 48.1s 43.8s 43.0s 43.6s 47.6s
Times for minikube (PR 11593) start: 47.2s 46.8s 43.2s 47.3s 46.9s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11593) |
+----------------+----------+---------------------+
| minikube start | 49.0s    | 47.9s               |
| enable ingress | 34.3s    | 34.5s               |
+----------------+----------+---------------------+

Times for minikube start: 51.6s 48.2s 47.8s 50.8s 46.7s
Times for minikube (PR 11593) start: 48.7s 47.3s 49.3s 48.5s 45.8s

Times for minikube ingress: 34.8s 33.8s 34.2s 34.7s 34.2s
Times for minikube (PR 11593) ingress: 34.3s 36.3s 32.3s 34.3s 35.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11593) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 21.8s               |
| enable ingress | 29.5s    | 29.1s               |
+----------------+----------+---------------------+

Times for minikube (PR 11593) start: 21.0s 22.1s 21.2s 22.0s 22.6s
Times for minikube start: 22.7s 21.8s 21.8s 23.1s 22.0s

Times for minikube (PR 11593) ingress: 31.5s 26.5s 28.0s 28.5s 31.0s
Times for minikube ingress: 27.5s 30.5s 28.5s 29.5s 31.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11593) |
+----------------+----------+---------------------+
| minikube start | 42.8s    | 40.7s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube (PR 11593) start: 45.6s 29.4s 43.3s 43.4s 41.8s
Times for minikube start: 31.1s 47.4s 43.8s 43.9s 47.8s

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2021
@medyagh medyagh changed the title Upgrade Docker, from 20.10.6 to 20.10.7 ISO: Upgrade Docker, from 20.10.6 to 20.10.7 Jun 11, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11593) |
+----------------+----------+---------------------+
| minikube start | 46.6s    | 47.4s               |
| enable ingress | 40.1s    | 36.8s               |
+----------------+----------+---------------------+

Times for minikube start: 48.3s 45.6s 46.0s 46.8s 46.2s
Times for minikube (PR 11593) start: 46.7s 47.2s 48.1s 47.5s 47.3s

Times for minikube ingress: 41.7s 36.7s 42.2s 44.2s 35.7s
Times for minikube (PR 11593) ingress: 33.7s 36.2s 35.3s 36.7s 42.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11593) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 21.4s               |
| enable ingress | 35.4s    | 33.9s               |
+----------------+----------+---------------------+

Times for minikube start: 21.9s 22.1s 22.1s 21.1s 22.0s
Times for minikube (PR 11593) start: 21.1s 21.1s 21.2s 21.6s 21.9s

Times for minikube ingress: 35.0s 30.5s 37.5s 40.5s 33.5s
Times for minikube (PR 11593) ingress: 32.0s 32.0s 33.0s 34.5s 38.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11593) |
+----------------+----------+---------------------+
| minikube start | 42.0s    | 45.0s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.4s 43.5s 43.1s 49.0s 43.1s
Times for minikube (PR 11593) start: 43.0s 47.4s 43.7s 43.6s 47.2s

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11593) |
+----------------+----------+---------------------+
| minikube start | 48.4s    | 46.9s               |
| enable ingress | 34.2s    | 34.3s               |
+----------------+----------+---------------------+

Times for minikube (PR 11593) start: 45.8s 47.0s 46.5s 47.8s 47.1s
Times for minikube start: 49.5s 48.6s 47.3s 50.4s 46.0s

Times for minikube ingress: 33.8s 34.2s 34.3s 34.2s 34.4s
Times for minikube (PR 11593) ingress: 34.3s 35.7s 34.2s 34.2s 32.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11593) |
+----------------+----------+---------------------+
| minikube start | 21.8s    | 21.4s               |
| enable ingress | 28.8s    | 31.9s               |
+----------------+----------+---------------------+

Times for minikube start: 22.3s 21.6s 22.2s 21.1s 21.6s
Times for minikube (PR 11593) start: 20.8s 21.8s 21.9s 21.3s 21.3s

Times for minikube ingress: 26.5s 30.0s 30.0s 30.0s 27.5s
Times for minikube (PR 11593) ingress: 28.0s 36.5s 37.0s 29.5s 28.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11593) |
+----------------+----------+---------------------+
| minikube start | 42.4s    | 44.7s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.8s 47.1s 47.1s 42.8s 43.1s
Times for minikube (PR 11593) start: 43.0s 47.8s 42.7s 46.9s 42.9s

@minikube-bot
Copy link
Collaborator

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests Flake Rate (%)
TestAddons/parallel/Ingress 0.00 (chart)
TestErrorSpam/setup 100.00 (chart)

    runc v1.0.0-rc95

    containerd v1.4.6
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11593) |
+----------------+----------+---------------------+
| minikube start | 47.5s    | 47.1s               |
| enable ingress | 38.5s    | 40.4s               |
+----------------+----------+---------------------+

Times for minikube start: 48.9s 47.1s 46.5s 48.0s 46.9s
Times for minikube (PR 11593) start: 46.5s 45.5s 47.8s 47.4s 48.4s

Times for minikube ingress: 36.3s 41.7s 36.3s 43.8s 34.3s
Times for minikube (PR 11593) ingress: 43.3s 34.2s 44.3s 38.3s 41.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11593) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 22.1s               |
| enable ingress | 36.0s    | 34.4s               |
+----------------+----------+---------------------+

Times for minikube start: 24.0s 21.3s 22.2s 21.9s 21.1s
Times for minikube (PR 11593) start: 22.1s 21.9s 22.7s 22.5s 21.6s

Times for minikube ingress: 34.0s 38.5s 34.0s 36.5s 37.0s
Times for minikube (PR 11593) ingress: 34.0s 34.0s 36.0s 34.5s 33.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11593) |
+----------------+----------+---------------------+
| minikube start | 41.6s    | 43.8s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.2s 43.4s 43.1s 46.9s 43.5s
Times for minikube (PR 11593) start: 42.1s 43.1s 43.3s 46.9s 43.5s

@minikube-bot
Copy link
Collaborator

These are the flake rates of all failed tests on Docker_Linux.

Failed Tests Flake Rate (%)
TestNetworkPlugins/group/calico/DNS 0.00 (chart)

@minikube-bot
Copy link
Collaborator

These are the flake rates of all failed tests on Docker_Linux_containerd.

Failed Tests Flake Rate (%)
TestFunctional/parallel/LogsCmd 5.19 (chart)
TestFunctional/parallel/LogsFileCmd 5.19 (chart)

@minikube-bot
Copy link
Collaborator

These are the flake rates of all failed tests on KVM_Linux.

Failed Tests Flake Rate (%)
TestNetworkPlugins/group/cilium/DNS 6.50 (chart)

@minikube-bot
Copy link
Collaborator

These are the flake rates of all failed tests on KVM_Linux_containerd.

Failed Tests Flake Rate (%)
TestNetworkPlugins/group/cilium/DNS 6.06 (chart)

@medyagh
Copy link
Member

medyagh commented Jul 5, 2021

Ok-to-build-iso

@medyagh
Copy link
Member

medyagh commented Jul 5, 2021

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @afbjorklund, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@k8s-ci-robot
Copy link
Contributor

@afbjorklund: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2021
@k8s-ci-robot
Copy link
Contributor

@afbjorklund: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-minikube-build a644a23 link /test pull-minikube-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11593) |
+----------------+----------+---------------------+
| minikube start | 47.3s    | 46.6s               |
| enable ingress | 34.4s    | 33.9s               |
+----------------+----------+---------------------+

Times for minikube (PR 11593) start: 47.3s 46.3s 46.5s 45.9s 46.9s
Times for minikube start: 50.0s 46.1s 46.6s 47.1s 46.5s

Times for minikube ingress: 35.3s 33.3s 34.8s 33.7s 35.2s
Times for minikube (PR 11593) ingress: 33.2s 34.7s 34.8s 34.2s 32.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11593) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.9s               |
| enable ingress | 29.6s    | 30.9s               |
+----------------+----------+---------------------+

Times for minikube start: 21.6s 21.6s 21.7s 22.3s 20.7s
Times for minikube (PR 11593) start: 23.4s 21.5s 21.6s 22.2s 20.6s

Times for minikube ingress: 27.5s 31.5s 28.0s 32.5s 28.5s
Times for minikube (PR 11593) ingress: 31.0s 31.5s 34.0s 29.5s 28.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11593) |
+----------------+----------+---------------------+
| minikube start | 44.8s    | 41.8s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 47.2s 43.4s 46.8s 43.1s 43.5s
Times for minikube (PR 11593) start: 31.1s 43.0s 47.5s 43.9s 43.4s

@minikube-bot
Copy link
Collaborator

These are the flake rates of all failed tests on KVM_Linux.

Failed Tests Flake Rate (%)
TestAddons/parallel/Olm 1.42 (chart)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants