Add auto-pause to VMs #11019

medyagh · 2021-04-08T02:37:09Z

After this PR auto-pause addon will be available on VMs

k8s-ci-robot · 2021-04-08T02:37:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

medyagh · 2021-04-08T02:37:43Z

/ok-to-build-iso

medyagh · 2021-04-08T05:18:51Z

ok-to-build-iso

minikube-bot · 2021-04-08T06:21:14Z

Hi @medyagh, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

medyagh · 2021-04-08T16:59:38Z

ok-to-build-image

minikube-bot · 2021-04-08T17:17:38Z

Hi @medyagh, building a new kicbase image failed, with the error below:

	<details>
	<pre>
	PATH="/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/usr/local/go/bin:/home/jenkins/go/bin:/home/jenkins/go/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...

gofmt -s -w pkg/minikube/assets/assets.go
PATH="/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/usr/local/go/bin:/home/jenkins/go/bin:/home/jenkins/go/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
GOOS=linux GOARCH=amd64 go build -o deploy/kicbase/auto-pause cmd/auto-pause/auto-pause.go
env DOCKER_CLI_EXPERIMENTAL=enabled docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
Setting /usr/bin/qemu-alpha-static as binfmt interpreter for alpha
Setting /usr/bin/qemu-arm-static as binfmt interpreter for arm
Setting /usr/bin/qemu-armeb-static as binfmt interpreter for armeb
Setting /usr/bin/qemu-sparc-static as binfmt interpreter for sparc
Setting /usr/bin/qemu-sparc32plus-static as binfmt interpreter for sparc32plus
Setting /usr/bin/qemu-sparc64-static as binfmt interpreter for sparc64
Setting /usr/bin/qemu-ppc-static as binfmt interpreter for ppc
Setting /usr/bin/qemu-ppc64-static as binfmt interpreter for ppc64
Setting /usr/bin/qemu-ppc64le-static as binfmt interpreter for ppc64le
Setting /usr/bin/qemu-m68k-static as binfmt interpreter for m68k
Setting /usr/bin/qemu-mips-static as binfmt interpreter for mips
Setting /usr/bin/qemu-mipsel-static as binfmt interpreter for mipsel
Setting /usr/bin/qemu-mipsn32-static as binfmt interpreter for mipsn32
Setting /usr/bin/qemu-mipsn32el-static as binfmt interpreter for mipsn32el
Setting /usr/bin/qemu-mips64-static as binfmt interpreter for mips64
Setting /usr/bin/qemu-mips64el-static as binfmt interpreter for mips64el
Setting /usr/bin/qemu-sh4-static as binfmt interpreter for sh4
Setting /usr/bin/qemu-sh4eb-static as binfmt interpreter for sh4eb
Setting /usr/bin/qemu-s390x-static as binfmt interpreter for s390x
Setting /usr/bin/qemu-aarch64-static as binfmt interpreter for aarch64
Setting /usr/bin/qemu-aarch64_be-static as binfmt interpreter for aarch64_be
Setting /usr/bin/qemu-hppa-static as binfmt interpreter for hppa
Setting /usr/bin/qemu-riscv32-static as binfmt interpreter for riscv32
Setting /usr/bin/qemu-riscv64-static as binfmt interpreter for riscv64
Setting /usr/bin/qemu-xtensa-static as binfmt interpreter for xtensa
Setting /usr/bin/qemu-xtensaeb-static as binfmt interpreter for xtensaeb
Setting /usr/bin/qemu-microblaze-static as binfmt interpreter for microblaze
Setting /usr/bin/qemu-microblazeel-static as binfmt interpreter for microblazeel
Setting /usr/bin/qemu-or1k-static as binfmt interpreter for or1k
env DOCKER_CLI_EXPERIMENTAL=enabled docker buildx rm --builder minikube-builder || true
env DOCKER_CLI_EXPERIMENTAL=enabled docker buildx create --name minikube-builder --buildkitd-flags '--debug' || true
minikube-builder
Image doesn't exist in registry
Image doesn't exist in registry
⚠️ 'Are you sure you want to push gcr.io/k8s-minikube/kicbase-builds:v0.0.19-1617901701-11019 kicbase/build:v0.0.19-1617901701-11019 ?'
env DOCKER_CLI_EXPERIMENTAL=enabled docker buildx build --builder minikube-builder --platform linux/arm64,linux/amd64 -t gcr.io/k8s-minikube/kicbase-builds:v0.0.19-1617901701-11019 -t kicbase/build:v0.0.19-1617901701-11019 --push --build-arg COMMIT_SHA=v1.19.0-beta.0-"61832c387ad79fff7cc72e3a0be41b7474a229b9" ./deploy/kicbase

	Full logs are at https://storage.cloud.google.com/minikube-builds/logs/11019/3d994a6/kic_image_build.txt

medyagh · 2021-04-08T17:26:31Z

ok-to-build-image

minikube-bot · 2021-04-08T17:44:19Z

Hi @medyagh, building a new kicbase image failed, with the error below:

	<details>
	<pre>
	PATH="/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/usr/local/go/bin:/home/jenkins/go/bin:/home/jenkins/go/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...

gofmt -s -w pkg/minikube/assets/assets.go
PATH="/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/usr/local/go/bin:/home/jenkins/go/bin:/home/jenkins/go/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
GOOS=linux GOARCH=amd64 go build -o deploy/kicbase/auto-pause cmd/auto-pause/auto-pause.go
env DOCKER_CLI_EXPERIMENTAL=enabled docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
Setting /usr/bin/qemu-alpha-static as binfmt interpreter for alpha
Setting /usr/bin/qemu-arm-static as binfmt interpreter for arm
Setting /usr/bin/qemu-armeb-static as binfmt interpreter for armeb
Setting /usr/bin/qemu-sparc-static as binfmt interpreter for sparc
Setting /usr/bin/qemu-sparc32plus-static as binfmt interpreter for sparc32plus
Setting /usr/bin/qemu-sparc64-static as binfmt interpreter for sparc64
Setting /usr/bin/qemu-ppc-static as binfmt interpreter for ppc
Setting /usr/bin/qemu-ppc64-static as binfmt interpreter for ppc64
Setting /usr/bin/qemu-ppc64le-static as binfmt interpreter for ppc64le
Setting /usr/bin/qemu-m68k-static as binfmt interpreter for m68k
Setting /usr/bin/qemu-mips-static as binfmt interpreter for mips
Setting /usr/bin/qemu-mipsel-static as binfmt interpreter for mipsel
Setting /usr/bin/qemu-mipsn32-static as binfmt interpreter for mipsn32
Setting /usr/bin/qemu-mipsn32el-static as binfmt interpreter for mipsn32el
Setting /usr/bin/qemu-mips64-static as binfmt interpreter for mips64
Setting /usr/bin/qemu-mips64el-static as binfmt interpreter for mips64el
Setting /usr/bin/qemu-sh4-static as binfmt interpreter for sh4
Setting /usr/bin/qemu-sh4eb-static as binfmt interpreter for sh4eb
Setting /usr/bin/qemu-s390x-static as binfmt interpreter for s390x
Setting /usr/bin/qemu-aarch64-static as binfmt interpreter for aarch64
Setting /usr/bin/qemu-aarch64_be-static as binfmt interpreter for aarch64_be
Setting /usr/bin/qemu-hppa-static as binfmt interpreter for hppa
Setting /usr/bin/qemu-riscv32-static as binfmt interpreter for riscv32
Setting /usr/bin/qemu-riscv64-static as binfmt interpreter for riscv64
Setting /usr/bin/qemu-xtensa-static as binfmt interpreter for xtensa
Setting /usr/bin/qemu-xtensaeb-static as binfmt interpreter for xtensaeb
Setting /usr/bin/qemu-microblaze-static as binfmt interpreter for microblaze
Setting /usr/bin/qemu-microblazeel-static as binfmt interpreter for microblazeel
Setting /usr/bin/qemu-or1k-static as binfmt interpreter for or1k
env DOCKER_CLI_EXPERIMENTAL=enabled docker buildx rm --builder minikube-builder || true
env DOCKER_CLI_EXPERIMENTAL=enabled docker buildx create --name minikube-builder --buildkitd-flags '--debug' || true
minikube-builder
Image doesn't exist in registry
Image doesn't exist in registry
⚠️ 'Are you sure you want to push gcr.io/k8s-minikube/kicbase-builds:v0.0.19-1617903310-11019 kicbase/build:v0.0.19-1617903310-11019 ?'
env DOCKER_CLI_EXPERIMENTAL=enabled docker buildx build --builder minikube-builder --platform linux/arm64,linux/amd64 -t gcr.io/k8s-minikube/kicbase-builds:v0.0.19-1617903310-11019 -t kicbase/build:v0.0.19-1617903310-11019 --push --build-arg COMMIT_SHA=v1.19.0-beta.0-"61832c387ad79fff7cc72e3a0be41b7474a229b9" ./deploy/kicbase

	Full logs are at https://storage.cloud.google.com/minikube-builds/logs/11019/3d994a6/kic_image_build.txt

medyagh · 2021-04-08T17:58:50Z

ok-to-build-image

minikube-bot · 2021-04-08T18:17:39Z

Hi @medyagh, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

medyagh · 2021-04-08T18:19:15Z

/ok-to-test

ilya-zuyev

How about a short description what this PR changes in VM drivers behavior?

ilya-zuyev · 2021-04-08T18:42:31Z

pkg/drivers/kic/types.go

 	// The name of the Dockerhub kicbase repository
-	dockerhubRepo = "kicbase/stable"
+	dockerhubRepo = "kicbase/build"


Do we need to merge this change? Are we going to use 'build' repo in release version?

after PR is merged we will need to release stable kic
in a separaete PR

Got it. Just curious, this PR is about VM/ISO, why do we have changes related to kicbase here?

we moved where the auto-pause binary lives, so there needed to be a corresponding change in kicbase's Dockerfile. any kicbase change needs a rebuild.

yes, the VM only we could add binaries into this path, and needed to change the systemd to direct to this

minikube-pr-bot · 2021-04-08T19:32:24Z

kvm2 Driver
Times for minikube: 100.5s 103.3s 101.5s
Average time for minikube: 101.8s

Times for Minikube (PR 11019): 108.0s 103.2s 100.1s
Average time for Minikube (PR 11019): 103.8s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 11019) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.19.0-beta.0 on               | 0.0s     | 0.0s                |
| Debian 9.11 (kvm/amd64)                    |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 32.7s    | 33.8s               |
| Memory=4000MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.5             | 1.8s     | 1.6s                |
| on Docker 20.10.4 ...                      |          |                     |
|   - Generating certificates                | 2.2s     | 2.7s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 59.9s    | 59.6s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.3s     | 1.3s                |
| * Verifying Kubernetes                     | 0.0s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 3.8s     | 3.8s                |
| gcr.io/k8s-minikube/storage-provisioner:v5 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 180.3s 169.9s 119.3s
Average time for minikube: 156.5s

Times for Minikube (PR 11019): 126.2s 107.2s 107.7s
Average time for Minikube (PR 11019): 113.7s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 11019) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.19.0-beta.0 on               | 0.1s     | 0.1s                |
| Debian 9.11 (kvm/amd64)                    |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 6.7s     | 8.0s                |
| (CPUs=2, Memory=4000MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.5             | 149.0s   | 99.9s               |
| on Docker 20.10.5 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 0.4s     | 0.6s                |
| gcr.io/k8s-minikube/storage-provisioner:v5 |          |                     |
| * Enabled addons:                          | 0.0s     | 0.0s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

…topause-vm

minikube-pr-bot · 2021-04-08T21:59:10Z

kvm2 Driver
Times for minikube: 49.5s 51.6s 51.1s
Average time for minikube: 50.7s

Times for Minikube (PR 11019): 49.7s 51.7s 52.4s
Average time for Minikube (PR 11019): 51.3s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 11019) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.19.0-beta.0 on               | 0.0s     | 0.0s                |
| Debian 9.11 (kvm/amd64)                    |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 33.1s    | 33.3s               |
| Memory=4000MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 2.0s     | 1.4s                |
| on Docker 20.10.4 ...                      |          |                     |
|   - Generating certificates                | 1.8s     | 3.0s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 11.3s    | 10.8s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.5s     | 1.6s                |
| * Verifying Kubernetes                     | 0.0s     | 0.0s                |
| components...                              |          |                     |
|   - Using image                            | 0.9s     | 0.9s                |
| gcr.io/k8s-minikube/storage-provisioner:v5 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.2s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 19.2s 20.2s 19.3s
Average time for minikube: 19.5s

Times for Minikube (PR 11019): 19.2s 19.4s 19.3s
Average time for Minikube (PR 11019): 19.3s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 11019) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.19.0-beta.0 on               | 0.1s     | 0.1s                |
| Debian 9.11 (kvm/amd64)                    |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 7.0s     | 7.0s                |
| (CPUs=2, Memory=4000MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 11.4s    | 11.2s               |
| on Docker 20.10.5 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 0.7s     | 0.7s                |
| gcr.io/k8s-minikube/storage-provisioner:v5 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

add auto-pause to VMs

d1c46ae

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 8, 2021

k8s-ci-robot requested review from prezha and tstromberg April 8, 2021 02:37

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2021

Updating ISO to v1.19.0-1617859429-11019

61aa26d

medyagh added 2 commits April 8, 2021 09:56

change location of auto-pause binary

1cda7d4

remove phony

3d994a6

revert pipefail

1665c78

medyagh mentioned this pull request Apr 8, 2021

set -x -o pipefail will cause Kic Build Job to fail #11025

Closed

Updating kicbase image to v0.0.19-1617905290-11019

831c3df

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2021

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 8, 2021

ilya-zuyev self-requested a review April 8, 2021 18:38

ilya-zuyev reviewed Apr 8, 2021

View reviewed changes

Merge branch 'master' of github.com:kubernetes/minikube into medya-au…

ffba51f

…topause-vm

kubernetes deleted a comment from minikube-pr-bot Apr 8, 2021

medyagh changed the title ~~add auto-pause to VMs~~ Add auto-pause to VMs Apr 8, 2021

medyagh merged commit 5a17d80 into kubernetes:master Apr 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add auto-pause to VMs #11019

Add auto-pause to VMs #11019

medyagh commented Apr 8, 2021 •

edited

Loading

k8s-ci-robot commented Apr 8, 2021

medyagh commented Apr 8, 2021

medyagh commented Apr 8, 2021

minikube-bot commented Apr 8, 2021

medyagh commented Apr 8, 2021

minikube-bot commented Apr 8, 2021

medyagh commented Apr 8, 2021

minikube-bot commented Apr 8, 2021

medyagh commented Apr 8, 2021

minikube-bot commented Apr 8, 2021

medyagh commented Apr 8, 2021

ilya-zuyev left a comment

ilya-zuyev Apr 8, 2021 •

edited

Loading

medyagh Apr 8, 2021

ilya-zuyev Apr 8, 2021

sharifelgamal Apr 8, 2021

medyagh Apr 8, 2021

minikube-pr-bot commented Apr 8, 2021

minikube-pr-bot commented Apr 8, 2021

Add auto-pause to VMs #11019

Add auto-pause to VMs #11019

Conversation

medyagh commented Apr 8, 2021 • edited Loading

k8s-ci-robot commented Apr 8, 2021

medyagh commented Apr 8, 2021

medyagh commented Apr 8, 2021

minikube-bot commented Apr 8, 2021

medyagh commented Apr 8, 2021

minikube-bot commented Apr 8, 2021

medyagh commented Apr 8, 2021

minikube-bot commented Apr 8, 2021

medyagh commented Apr 8, 2021

minikube-bot commented Apr 8, 2021

medyagh commented Apr 8, 2021

ilya-zuyev left a comment

Choose a reason for hiding this comment

ilya-zuyev Apr 8, 2021 • edited Loading

Choose a reason for hiding this comment

medyagh Apr 8, 2021

Choose a reason for hiding this comment

ilya-zuyev Apr 8, 2021

Choose a reason for hiding this comment

sharifelgamal Apr 8, 2021

Choose a reason for hiding this comment

medyagh Apr 8, 2021

Choose a reason for hiding this comment

minikube-pr-bot commented Apr 8, 2021

minikube-pr-bot commented Apr 8, 2021

medyagh commented Apr 8, 2021 •

edited

Loading

ilya-zuyev Apr 8, 2021 •

edited

Loading