Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestErrorJSONOutput test #10463

Merged
merged 1 commit into from
Feb 13, 2021

Conversation

ilya-zuyev
Copy link
Contributor

This PR fixes TestErrorJSONOutput integration test
The problem was that after #10452 the error message about incorrect minikube driver changed from The driver ${driver} is not supported on ${os} to The driver ${driver} is not supported on ${os}/${arch}

Before:

➜  minikube git:(master) go test  -v -test.timeout=20m ./test/integration --tags=integration -test.run TestErrorJSONOutput
Found 12 cores, limiting parallelism with --test.parallel=6
=== RUN   TestErrorJSONOutput
    json_output_test.go:144: (dbg) Run:  out/minikube start -p json-output-error-20210212151048-59605 --memory=2200 --output=json --wait=true --driver=fail
    json_output_test.go:144: (dbg) Non-zero exit: out/minikube start -p json-output-error-20210212151048-59605 --memory=2200 --output=json --wait=true --driver=fail: exit status 56 (369.230899ms)
        
        -- stdout --
                {"data":{"currentstep":"0","message":"[json-output-error-20210212151048-59605] minikube v1.17.1 on Darwin 11.2","name":"Initial Minikube Setup","totalsteps":"18"},"datacontenttype":"application/json","id":"872f7d71-07b2-46a1-a1ba-d923f06360db","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.step"}
                {"data":{"advice":"","exitcode":"56","issues":"","message":"The driver 'fail' is not supported on darwin/amd64","name":"DRV_UNSUPPORTED_OS","url":""},"datacontenttype":"application/json","id":"cdde7759-4ee5-4c12-b363-a3a134dc9371","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.error"}
        
        -- /stdout --
    json_output_test.go:184: values in cloud events do not match:
        Actual:
        'The driver 'fail' is not supported on darwin/amd64'
        Expected:
        'The driver 'fail' is not supported on darwin'
    helpers_test.go:171: Cleaning up "json-output-error-20210212151048-59605" profile ...
    helpers_test.go:174: (dbg) Run:  out/minikube delete -p json-output-error-20210212151048-59605
    helpers_test.go:174: (dbg) Done: out/minikube delete -p json-output-error-20210212151048-59605: (3.615536727s)
--- FAIL: TestErrorJSONOutput (3.99s)
FAIL
Tests completed in 3.985965147s (result code 1)
FAIL    k8s.io/minikube/test/integration        4.967s
FAIL

After:

➜  minikube git:(ilyaz/fix_TestErrorJSONOutput) go test  -v -test.timeout=20m ./test/integration --tags=integration -test.run TestErrorJSONOutput
Found 12 cores, limiting parallelism with --test.parallel=6
=== RUN   TestErrorJSONOutput
    json_output_test.go:144: (dbg) Run:  out/minikube start -p json-output-error-20210212151018-59313 --memory=2200 --output=json --wait=true --driver=fail
    json_output_test.go:144: (dbg) Non-zero exit: out/minikube start -p json-output-error-20210212151018-59313 --memory=2200 --output=json --wait=true --driver=fail: exit status 56 (444.152326ms)
        
        -- stdout --
                {"data":{"currentstep":"0","message":"[json-output-error-20210212151018-59313] minikube v1.17.1 on Darwin 11.2","name":"Initial Minikube Setup","totalsteps":"18"},"datacontenttype":"application/json","id":"7b12189d-9480-4689-ab68-fd97ecd36618","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.step"}
                {"data":{"advice":"","exitcode":"56","issues":"","message":"The driver 'fail' is not supported on darwin/amd64","name":"DRV_UNSUPPORTED_OS","url":""},"datacontenttype":"application/json","id":"fa0542ac-584a-451b-a656-88b3c1b979f9","source":"https://minikube.sigs.k8s.io/","specversion":"1.0","type":"io.k8s.sigs.minikube.error"}
        
        -- /stdout --
    helpers_test.go:171: Cleaning up "json-output-error-20210212151018-59313" profile ...
    helpers_test.go:174: (dbg) Run:  out/minikube delete -p json-output-error-20210212151018-59313
    helpers_test.go:174: (dbg) Done: out/minikube delete -p json-output-error-20210212151018-59313: (3.486683144s)
--- PASS: TestErrorJSONOutput (3.93s)
PASS
Tests completed in 3.932005807s (result code 0)
ok      k8s.io/minikube/test/integration        4.784s

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ilya-zuyev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2021
@medyagh
Copy link
Member

medyagh commented Feb 12, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 12, 2021
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10463): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10463/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10463/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10463): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10463/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10463/minikube: exec format error

@medyagh medyagh merged commit a99c6c2 into kubernetes:master Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants