Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove crio restart hack #10412

Merged
merged 2 commits into from
Feb 11, 2021
Merged

remove crio restart hack #10412

merged 2 commits into from
Feb 11, 2021

Conversation

sharifelgamal
Copy link
Collaborator

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 9, 2021
@sharifelgamal
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 9, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2021
@kubernetes kubernetes deleted a comment from minikube-pr-bot Feb 9, 2021
@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 63.7s 66.0s 65.9s
Average time for minikube: 65.2s

Times for Minikube (PR 10412): 67.9s 65.5s 64.3s
Average time for Minikube (PR 10412): 65.9s

Averages Time Per Log

+--------------------------------+----------+---------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 10412) |
+--------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian   | 0.0s     | 0.0s                |
| 9.11 (kvm/amd64)               |          |                     |
| * Using the kvm2 driver based  | 0.0s     | 0.0s                |
| on user configuration          |          |                     |
| * Starting control plane node  | 0.0s     | 0.0s                |
| minikube in cluster minikube   |          |                     |
| * Creating kvm2 VM (CPUs=2,    | 40.1s    | 40.7s               |
| Memory=3700MB, Disk=20000MB)   |          |                     |
| ...                            |          |                     |
| * Preparing Kubernetes v1.20.2 | 8.8s     | 2.0s                |
| on Docker 20.10.2 ...          |          |                     |
|   - Generating certificates    | 2.8s     | 4.3s                |
| and keys ...                   |          |                     |
|   - Booting up control plane   | 9.9s     | 15.5s               |
| ...                            |          |                     |
|   - Configuring RBAC rules ... | 1.2s     | 1.3s                |
| * Verifying Kubernetes         | 1.5s     | 1.4s                |
| components...                  |          |                     |
| * Enabled addons:              | 0.6s     |                     |
| storage-provisioner,           |          |                     |
| default-storageclass           |          |                     |
| * Done! kubectl is now         | 0.0s     | 0.0s                |
| configured to use "minikube"   |          |                     |
| cluster and "default"          |          |                     |
| namespace by default           |          |                     |
+--------------------------------+----------+---------------------+

docker Driver
Times for minikube: 25.0s 25.1s 26.5s
Average time for minikube: 25.6s

Times for Minikube (PR 10412): 24.2s 24.3s 25.6s
Average time for Minikube (PR 10412): 24.7s

Averages Time Per Log

+--------------------------------+----------+---------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 10412) |
+--------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian   | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)               |          |                     |
| * Using the docker driver      | 0.1s     | 0.1s                |
| based on user configuration    |          |                     |
| * Starting control plane node  | 0.1s     | 0.1s                |
| minikube in cluster minikube   |          |                     |
| * Creating docker container    | 9.6s     | 9.4s                |
| (CPUs=2, Memory=3700MB) ...    |          |                     |
| * Preparing Kubernetes v1.20.2 | 14.6s    | 14.0s               |
| on Docker 20.10.2 ...          |          |                     |
| * Verifying Kubernetes         | 0.9s     | 0.8s                |
| components...                  |          |                     |
| * Enabled addons:              | 0.1s     | 0.1s                |
| storage-provisioner,           |          |                     |
| default-storageclass           |          |                     |
| * Done! kubectl is now         | 0.0s     | 0.0s                |
| configured to use "minikube"   |          |                     |
| cluster and "default"          |          |                     |
| namespace by default           |          |                     |
+--------------------------------+----------+---------------------+

medyagh
medyagh requested changes Feb 9, 2021
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belive we no longer test crio at all
we need to add Jenkins job for CRIO simmilar to containerd
as part of this PR I think we should create a job simmilar to https://a646c87040050000000000000000001.proxy.googleprod.com/job/Docker_Linux_containerd_integration/
(at least for Docker Driver and one of the VM driver ones KVM)

@afbjorklund
Copy link
Collaborator

Did something actually change upstream ?

@sharifelgamal
Copy link
Collaborator Author

Did something actually change upstream ?

It's been a few releases since we tried to remove this, so this is more of a test than anything.

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 67.2s 69.7s 69.9s
Average time for minikube: 68.9s

Times for Minikube (PR 10412): 66.7s 67.9s 66.1s
Average time for Minikube (PR 10412): 66.9s

Averages Time Per Log

+--------------------------------+----------+---------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 10412) |
+--------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian   | 0.0s     | 0.0s                |
| 9.11 (kvm/amd64)               |          |                     |
| * Using the kvm2 driver based  | 0.0s     | 0.0s                |
| on user configuration          |          |                     |
| * Starting control plane node  | 0.0s     | 0.0s                |
| minikube in cluster minikube   |          |                     |
| * Creating kvm2 VM (CPUs=2,    | 41.7s    | 40.9s               |
| Memory=3700MB, Disk=20000MB)   |          |                     |
| ...                            |          |                     |
| * Preparing Kubernetes v1.20.2 | 2.3s     | 8.7s                |
| on Docker 20.10.2 ...          |          |                     |
|   - Generating certificates    | 4.4s     | 2.7s                |
| and keys ...                   |          |                     |
|   - Booting up control plane   | 16.1s    | 10.8s               |
| ...                            |          |                     |
|   - Configuring RBAC rules ... | 1.7s     | 1.2s                |
| * Verifying Kubernetes         | 1.8s     | 1.7s                |
| components...                  |          |                     |
| * Enabled addons:              | 0.7s     | 0.4s                |
| storage-provisioner,           |          |                     |
| default-storageclass           |          |                     |
| * Done! kubectl is now         | 0.0s     | 0.0s                |
| configured to use "minikube"   |          |                     |
| cluster and "default"          |          |                     |
| namespace by default           |          |                     |
+--------------------------------+----------+---------------------+

docker Driver
Times for minikube: 27.9s 25.6s 27.4s
Average time for minikube: 27.0s

Times for Minikube (PR 10412): 28.2s 27.3s 25.6s
Average time for Minikube (PR 10412): 27.0s

Averages Time Per Log

+--------------------------------+----------+---------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 10412) |
+--------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian   | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)               |          |                     |
| * Using the docker driver      | 0.1s     | 0.1s                |
| based on user configuration    |          |                     |
| * Starting control plane node  | 0.1s     | 0.1s                |
| minikube in cluster minikube   |          |                     |
| * Creating docker container    | 9.8s     | 10.6s               |
| (CPUs=2, Memory=3700MB) ...    |          |                     |
| * Preparing Kubernetes v1.20.2 | 15.7s    | 15.0s               |
| on Docker 20.10.2 ...          |          |                     |
| * Verifying Kubernetes         | 0.9s     | 0.9s                |
| components...                  |          |                     |
| * Enabled addons:              | 0.1s     | 0.1s                |
| storage-provisioner,           |          |                     |
| default-storageclass           |          |                     |
| * Done! kubectl is now         | 0.0s     | 0.0s                |
| configured to use "minikube"   |          |                     |
| cluster and "default"          |          |                     |
| namespace by default           |          |                     |
+--------------------------------+----------+---------------------+

medyagh
medyagh requested changes Feb 9, 2021
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRIO test is timing out (doesnt run all tests)

@medyagh medyagh merged commit 984b079 into kubernetes:master Feb 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@ilya-zuyev ilya-zuyev Awaiting requested review from ilya-zuyev

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sharifelgamal @minikube-pr-bot @afbjorklund @k8s-ci-robot @medyagh