Merge pull request #12990 from spowelljr/btrfsErrorMessage

Add advice if user using btrfs storage driver
kubernetes · Dec 4, 2021 · f1d63df · f1d63df
2 parents cb8c008 + c8fbd6e
commit f1d63df
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/cmd/minikube/cmd/start_flags.go b/cmd/minikube/cmd/start_flags.go
@@ -516,12 +516,19 @@ func generateNewConfigFromFlags(cmd *cobra.Command, k8sVersion string, drvName s
 			// See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-in-userns/
 			cc.KubernetesConfig.FeatureGates = addFeatureGate(cc.KubernetesConfig.FeatureGates, "KubeletInUserNamespace=true")
 		}
+		if si.StorageDriver == "btrfs" {
+			klog.Info("auto-setting LocalStorageCapacityIsolation to false because using btrfs storage driver")
+			cc.KubernetesConfig.FeatureGates = addFeatureGate(cc.KubernetesConfig.FeatureGates, "LocalStorageCapacityIsolation=false")
+		}
 	}
 
 	return cc
 }
 
 func addFeatureGate(featureGates, s string) string {
+	if len(featureGates) == 0 {
+		return s
+	}
 	split := strings.Split(featureGates, ",")
 	m := make(map[string]struct{}, len(split))
 	for _, v := range split {

diff --git a/pkg/minikube/reason/known_issues.go b/pkg/minikube/reason/known_issues.go
@@ -1053,6 +1053,15 @@ var guestIssues = []match{
 		},
 		Regexp: re(`'/var/lib/dpkg': No such file or directory`),
 	},
+	{
+		Kind: Kind{
+			ID:       "GUEST_STORAGE_DRIVER_BTRFS",
+			ExitCode: ExGuestUnsupported,
+			Advice:   "minikube does not support the BTRFS storage driver yet, there is a workaround, add the following flag to your start command `--feature-gates=\"LocalStorageCapacityIsolation=false\"`",
+			Issues:   []int{7923},
+		},
+		Regexp: re(`unsupported graph driver: btrfs`),
+	},
 	{
 		Kind: Kind{
 			ID:       "GUEST_INCORRECT_ARCH",