Skip to content

Commit

Permalink
make docker driver highly prefered
Browse files Browse the repository at this point in the history
  • Loading branch information
medyagh committed Jul 1, 2020
1 parent c134ab8 commit 7564651
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 10 deletions.
11 changes: 1 addition & 10 deletions pkg/minikube/registry/drvs/docker/docker.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,21 +37,12 @@ import (
var docURL = "https://minikube.sigs.k8s.io/docs/drivers/docker/"

func init() {
priority := registry.Default
// Staged rollout for preferred:
// - Linux
// - Windows (once "service" command works)
// - macOS
if runtime.GOOS == "linux" {
priority = registry.Preferred
}

if err := registry.Register(registry.DriverDef{
Name: driver.Docker,
Config: configure,
Init: func() drivers.Driver { return kic.NewDriver(kic.Config{OCIBinary: oci.Docker}) },
Status: status,
Priority: priority,
Priority: registry.HighlyPreferred,
}); err != nil {
panic(fmt.Sprintf("register failed: %v", err))
}
Expand Down
2 changes: 2 additions & 0 deletions pkg/minikube/registry/registry.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ const (
Default
// Preferred is for drivers that use a native hypervisor interface
Preferred
// HighlyPreferred is the ultimate driver preferences
HighlyPreferred
)

// Registry contains all the supported driver definitions on the host
Expand Down

0 comments on commit 7564651

Please sign in to comment.