Merge tag 'v0.28.2' into multi-node

0.28.2 Release * tag 'v0.28.2': Fix docs for kvm2 Cut 0.28.2. Update KVM driver installation instructions. Fix a minor typo in docs/gpu.md Bump minikube-nvidia-driver-installer version to make it work again. Allow zsh completion to be autoloaded by compinit Fix the windows install upload. Update releases.json to include v0.28.1
kubernetes · Jul 30, 2018 · 3cf034a · 3cf034a
2 parents 50b47f7 + 23fc22e
commit 3cf034a
Show file tree

Hide file tree

Showing 9 changed files with 32 additions and 31 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Minikube Release Notes
 
+# Version 0.28.2 - 7/20/2018
+* Nvidia driver installation fixed [#2996](https://github.com/kubernetes/minikube/pull/2986)
+
 # Version 0.28.1 - 7/16/2018
 * vboxsf Host Mounting fixed (Linux Kernel version downgraded to 4.15 from 4.16) [#2986](https://github.com/kubernetes/minikube/pull/2986)
 * cri-tools udpated to 1.11.1 [#2986](https://github.com/kubernetes/minikube/pull/2986)

diff --git a/Makefile b/Makefile
@@ -15,7 +15,7 @@
 # Bump these on release
 VERSION_MAJOR ?= 0
 VERSION_MINOR ?= 28
-VERSION_BUILD ?= 1
+VERSION_BUILD ?= 2
 VERSION ?= v$(VERSION_MAJOR).$(VERSION_MINOR).$(VERSION_BUILD)
 DEB_VERSION ?= $(VERSION_MAJOR).$(VERSION_MINOR)-$(VERSION_BUILD)
 INSTALL_SIZE ?= $(shell du out/minikube-windows-amd64.exe | cut -f1)

diff --git a/cmd/minikube/cmd/completion.go b/cmd/minikube/cmd/completion.go
@@ -107,6 +107,8 @@ func GenerateBashCompletion(w io.Writer, cmd *cobra.Command) error {
 
 func GenerateZshCompletion(out io.Writer, cmd *cobra.Command) error {
 	zsh_initialization := `
+#compdef minikube
+
 __minikube_bash_source() {
 	alias shopt=':'
 	alias _expand=_bash_expand

diff --git a/deploy/addons/gpu/nvidia-driver-installer.yaml b/deploy/addons/gpu/nvidia-driver-installer.yaml
@@ -50,7 +50,7 @@ spec:
         hostPath:
           path: /
       initContainers:
-      - image: k8s.gcr.io/minikube-nvidia-driver-installer@sha256:85cbeadb8bee62a96079823e81915955af0959063ff522ec01522e4edda28f33
+      - image: k8s.gcr.io/minikube-nvidia-driver-installer@sha256:492d46f2bc768d6610ec5940b6c3c33c75e03e201cc8786e04cc488659fd6342
         name: nvidia-driver-installer
         resources:
           requests:

diff --git a/deploy/minikube/releases.json b/deploy/minikube/releases.json
@@ -1,4 +1,12 @@
 [
+  {
+      "name": "v0.28.1",
+      "checksums": {
+          "darwin": "7d9b67c4c716184d6a854fb91b08b99094356a44b51e315659b254fbd74022cc",
+          "linux": "af261082d0ba9eb2dc3836a4cd903a449bafcb8647c5d5cb555c4e9144093627",
+          "windows": "e94d8d597e1c876dc45d6f63254e296bc95ee5c98c0a06b28050f59dad7d90c7"
+      }
+  },
   {
       "name": "v0.28.0",
       "checksums": {

diff --git a/docs/drivers.md b/docs/drivers.md
@@ -24,21 +24,17 @@ To install the KVM2 driver, first install and configure the prereqs:
 
 ```shell
 # Install libvirt and qemu-kvm on your system, e.g.
-# Debian/Ubuntu (for Debian Stretch libvirt-bin it's been replaced with libvirt-clients and libvirt-daemon-system)
-$ sudo apt install libvirt-bin qemu-kvm
+# Debian/Ubuntu (for older Debian/Ubuntu versions, you may have to use libvirt-bin instead of libvirt-clients and libvirt-daemon-system)
+$ sudo apt install libvirt-clients libvirt-daemon-system qemu-kvm
 # Fedora/CentOS/RHEL
 $ sudo yum install libvirt-daemon-kvm qemu-kvm
 
-# Add yourself to the libvirtd group (use libvirt group for rpm based distros) so you don't need to sudo
-# Debian/Ubuntu (NOTE: For Ubuntu 17.04 change the group to `libvirt`)
-$ sudo usermod -a -G libvirtd $(whoami)
-# Fedora/CentOS/RHEL
+# Add yourself to the libvirt group so you don't need to sudo
+# NOTE: For older Debian/Ubuntu versions change the group to `libvirtd`
 $ sudo usermod -a -G libvirt $(whoami)
 
 # Update your current session for the group change to take effect
-# Debian/Ubuntu (NOTE: For Ubuntu 17.04 change the group to `libvirt`)
-$ newgrp libvirtd
-# Fedora/CentOS/RHEL
+# NOTE: For older Debian/Ubuntu versions change the group to `libvirtd`
 $ newgrp libvirt
 ```
 
@@ -60,23 +56,18 @@ Minikube is currently tested against [`docker-machine-driver-kvm` v0.10.0](https
 
 After following the instructions on the KVM driver releases page, you need to make sure that have the necessary packages and permissions by following these instructions:
 ```shell
-
 # Install libvirt and qemu-kvm on your system, e.g.
-# Debian/Ubuntu (for Debian Stretch libvirt-bin it's been replaced with libvirt-clients and libvirt-daemon-system)
-$ sudo apt install libvirt-bin qemu-kvm
+# Debian/Ubuntu (for older Debian/Ubuntu versions, you may have to use libvirt-bin instead of libvirt-clients and libvirt-daemon-system)
+$ sudo apt install libvirt-clients libvirt-daemon-system qemu-kvm
 # Fedora/CentOS/RHEL
 $ sudo yum install libvirt-daemon-kvm qemu-kvm
 
-# Add yourself to the libvirtd group (use libvirt group for rpm based distros) so you don't need to sudo
-# Debian/Ubuntu (NOTE: For Ubuntu 17.04 change the group to `libvirt`)
-$ sudo usermod -a -G libvirtd $(whoami)
-# Fedora/CentOS/RHEL
+# Add yourself to the libvirt group so you don't need to sudo
+# NOTE: For older Debian/Ubuntu versions change the group to `libvirtd`
 $ sudo usermod -a -G libvirt $(whoami)
 
 # Update your current session for the group change to take effect
-# Debian/Ubuntu (NOTE: For Ubuntu 17.04 change the group to `libvirt`)
-$ newgrp libvirtd
-# Fedora/CentOS/RHEL
+# NOTE: For older Debian/Ubuntu versions change the group to `libvirtd`
 $ newgrp libvirt
 ```
 

diff --git a/docs/gpu.md b/docs/gpu.md
@@ -30,7 +30,7 @@ host to the minikube VM. Doing so has a few prerequisites:
   you want to passthrough to the VM and all other devices that are in the IOMMU
   group of these GPUs.
 
-- Once you reboot the system after doing the above, you should be ready to you
+- Once you reboot the system after doing the above, you should be ready to use
   GPUs with kvm2. Run the following command to start minikube:
   ```
   minikube start --vm-driver kvm2 --gpu

diff --git a/hack/jenkins/release_github_page.sh b/hack/jenkins/release_github_page.sh
@@ -115,6 +115,7 @@ FILES_TO_UPLOAD=(
     'minikube-darwin-amd64'
     'minikube-darwin-amd64.sha256'
     'minikube-windows-amd64'
+    'minikube-windows-amd64.sha256'
     'minikube-installer.exe'
     "minikube_${DEB_VERSION}.deb"
     'docker-machine-driver-kvm2'

diff --git a/pkg/drivers/kvm/domain.go b/pkg/drivers/kvm/domain.go
@@ -85,21 +85,17 @@ const connectionErrorText = `
 Error connecting to libvirt socket.  Have you set up libvirt correctly?
 
 # Install libvirt and qemu-kvm on your system, e.g.
-# Debian/Ubuntu
-$ sudo apt install libvirt-bin qemu-kvm
+# Debian/Ubuntu (for older Debian/Ubuntu versions, you may have to use libvirt-bin instead of libvirt-clients and libvirt-daemon-system)
+$ sudo apt install libvirt-clients libvirt-daemon-system qemu-kvm
 # Fedora/CentOS/RHEL
 $ sudo yum install libvirt-daemon-kvm qemu-kvm
 
-# Add yourself to the libvirtd group (use libvirt group for rpm based distros) so you don't need to sudo
-# Debian/Ubuntu (NOTE: For Ubuntu 17.04 change the group to libvirt)
-$ sudo usermod -a -G libvirtd $(whoami)
-# Fedora/CentOS/RHEL
+# Add yourself to the libvirt group so you don't need to sudo
+# NOTE: For older Debian/Ubuntu versions change the group to [libvirtd]
 $ sudo usermod -a -G libvirt $(whoami)
 
 # Update your current session for the group change to take effect
-# Debian/Ubuntu (NOTE: For Ubuntu 17.04 change the group to libvirt)
-$ newgrp libvirtd
-# Fedora/CentOS/RHEL
+# NOTE: For older Debian/Ubuntu versions change the group to [libvirtd]
 $ newgrp libvirt
 
 Visit https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#kvm-driver for more information.