Skip to content

Commit

Permalink
include prereleases
Browse files Browse the repository at this point in the history
  • Loading branch information
prezha committed Apr 20, 2022
1 parent daf340b commit 138dc9d
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions cmd/minikube/cmd/config/kubernetes_version.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
"k8s.io/minikube/pkg/minikube/constants"
)

// supportedKubernetesVersions returns reverse-sort supported Kubernetes releases from GitHub that are in [constants.OldestKubernetesVersion, constants.NewestKubernetesVersion] range, excluding prereleases.
// supportedKubernetesVersions returns reverse-sort supported Kubernetes releases from GitHub that are in [constants.OldestKubernetesVersion, constants.NewestKubernetesVersion] range, including prereleases.
// in case it cannot get it from GitHub, in addition to [constants.NewestKubernetesVersion, constants.OldestKubernetesVersion], 'constants.DefaultKubernetesVersion' is also returned if different from 'constants.NewestKubernetesVersion'.
func supportedKubernetesVersions() (releases []string) {
minver := constants.OldestKubernetesVersion
Expand All @@ -50,10 +50,6 @@ func supportedKubernetesVersions() (releases []string) {
if !semver.IsValid(ver) {
continue
}
// skip pre-release versions
if rl.GetPrerelease() {
continue
}
// skip out-of-range versions
if (minver != "" && semver.Compare(minver, ver) == 1) || (maxver != "" && semver.Compare(ver, maxver) == 1) {
continue
Expand Down

0 comments on commit 138dc9d

Please sign in to comment.