Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the route table tag in the route reconcile loop #96545

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Update the route table tag in the route reconcile loop #96545

merged 1 commit into from
Nov 13, 2020

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Nov 13, 2020

What type of PR is this?

/kind bug

What this PR does / why we need it:
Update the route table tag in the route reconcile loop.

Which issue(s) this PR fixes:

Fixes kubernetes-sigs/cloud-provider-azure#420

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update the route table tag in the route reconcile loop

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/area provider/azure
/sig cloud-provider
/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/provider/azure Issues or PRs related to azure provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider labels Nov 13, 2020
@feiskyer
Copy link
Member

/milestone v1.20
since this is a critical bug fix for 1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2020
@nilo19 nilo19 force-pushed the bug/fix-route-tag branch 2 times, most recently from 55bb9da to bd00ddd Compare November 13, 2020 08:24
feiskyer
feiskyer reviewed Nov 13, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020
@nilo19
Copy link
Member Author

nilo19 commented Nov 13, 2020

/retest

@feiskyer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1c2f5c3 into kubernetes:master Nov 13, 2020
@nilo19 nilo19 deleted the bug/fix-route-tag branch November 13, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

Fix the route table tagging issue
3 participants
@nilo19 @feiskyer @k8s-ci-robot