Support custom tags for cloud provider managed resources #96450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
approved
feiskyer
reviewed
Nov 11, 2020
staging/src/k8s.io/legacy-cloud-providers/azure/azure_loadbalancer.go
Outdated
Show resolved
Hide resolved
feiskyer
reviewed
Nov 11, 2020
feiskyer
reviewed
Nov 11, 2020
staging/src/k8s.io/legacy-cloud-providers/azure/azure_loadbalancer.go
Outdated
Show resolved
Hide resolved
|
/milestone v1.20 |
nilo19
force-pushed
the
feature/support-tag
branch
5 times, most recently
from
1106aa8 to
2e60a3d
Compare
k8s-ci-robot
added
the
lgtm
|
/retest |
k8s-ci-robot
removed
the
lgtm
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
nilo19
force-pushed
the
feature/support-tag
branch
from
8166664 to
824528c
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
nilo19
force-pushed
the
feature/support-tag
branch
from
824528c to
b337157
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
|
/retest |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Support custom tags for cloud provider managed resources, including shared resources (LB, security group, and route table) and non-shared resources (public IP). For shared resources, introducing a new cloud config
tags: "a=b,c=d,...". For public IP, introducing a new service annotationservice.beta.kubernetes.io/azure-pip-tags: "a=b,c=d,...". The corresponding resources would be tagged as configured when creating the cluster or after restarting the controller manager.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig cloud-provider
/area provider/azure
/priority important-soon
/triage accepted