Azure: Support multiple standard load balancers in one cluster #96111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/cloudprovider
approved
|
/retest |
feiskyer
reviewed
Nov 4, 2020
| @@ -197,6 +197,12 @@ type Config struct { | |||
| // "external": for external LoadBalancer | |||
| // "all": for both internal and external LoadBalancer | |||
| PreConfiguredBackendPoolLoadBalancerTypes string `json:"preConfiguredBackendPoolLoadBalancerTypes,omitempty" yaml:"preConfiguredBackendPoolLoadBalancerTypes,omitempty"` | |||
| // EnableMultipleStandardLoadBalancers determines the behavior of the standard load balancer. If set to true | |||
| // there would be one standard load balancer per agent pool, which is similar with the behavior of the basic | |||
There was a problem hiding this comment.
s/per agent pool/per VMAS or VMSS/
| // there would be one standard load balancer per agent pool, which is similar with the behavior of the basic | ||
| // load balancer. Users could select the specific standard load balancer for their service by the service | ||
| // annotation `service.beta.kubernetes.io/azure-load-balancer-mode`, If set to false, the standard load balancer | ||
| // would keep the current behavior, which is one per cluster. In this case, the mode selection annotation would be ignored. |
There was a problem hiding this comment.
s/the standard load balancer would keep the current behavior, which is one per cluster/the same standard load balancer would be shared by all services in the cluster/
| ProvisioningState: to.StringPtr("Succeeded"), | ||
| IPConfigurations: &[]network.InterfaceIPConfiguration{ | ||
| { | ||
| InterfaceIPConfigurationPropertiesFormat: &network.InterfaceIPConfigurationPropertiesFormat{ |
There was a problem hiding this comment.
nit: add a helper function to reduce the duplicated codes
| return fmt.Sprintf("%s-%s", prefix, suffix), nil | ||
| agentpoolName := strings.Split(prefix, "-")[1] | ||
| agentpoolUUID := strings.Split(prefix, "-")[2] | ||
| availabilitySetName := fmt.Sprintf("%s-availabilitySet-%s", agentpoolName, agentpoolUUID) |
There was a problem hiding this comment.
availabilitySetName should be get from VM vm.AvailabilitySet.ID
nilo19
force-pushed
the
feature/support-multiple-slb
branch
from
b3a4cca to
f29efd7
Compare
k8s-ci-robot
added
size/XL
nilo19
force-pushed
the
feature/support-multiple-slb
branch
from
f29efd7 to
667b2be
Compare
|
/retest |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Currently, only one SLB is allowed per cluster. If users set the mode selection annotation when using the SLB, they would get an error. After this feature implemented, the users could choose if they want a single SLB (current behavior), or they want multiple SLBs, with one SLB binding to one VMAS/VMSS. If the annotation is not set, everything is unchanged: every agent node in the cluster would join the backend pool of the SLB and only one SLB is allowed. If the annotation is set to
__auto__ornodepool1Name,nodepool2Name, there would be a 1: 1 mapping between the SLBs and the VMAS/VMSS. Specifically, for__auto__mode, the SLB with the minimum load balancing rules would be selected to serve the newly created service; fornodepool1Name,nodepool2Namemode, the SLB of the given VMAS/VMSS with the minimum load balancing rules would be selected. In this way, users could set different outbound rules for different VMAS/VMSS. If there is no SLB of the given VMAS/VMSS, a new SLB would be created.Which issue(s) this PR fixes:
Fixes kubernetes-sigs/cloud-provider-azure#380
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig cloud-provider
/area provider/azure
/priority important-soon
/triage accepted