Fix misusage of RLock in timeCache lru.Cache.Get()

[auxten]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Lru's Get() method also updates the least recent usage information. So, we should not use RLock() and even RWLock here.
An alternative fix is just using github.com/hashicorp/golang-lru, but that will introduce more diffs. If that is the better fix, I can also do that.

Which issue(s) this PR fixes:

Fixes a potential race condition

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixes a regression in 1.19 with a race condition in kubelet pod handling

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @auxten. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[neolit123]

/ok-to-test
/priority backlog

[draveness]

/lgtm
/assign @yujuhong

[dims]

/assign @liggitt

Jordan, since this was added by you. please review

[liggitt]

good catch, thanks! can you also open a cherry-pick to release-1.19?

/lgtm
/approve
/milestone v1.20
/priority important-soon

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: auxten, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[auxten]

good catch, thanks! can you also open a cherry-pick to release-1.19?

/lgtm
/approve
/milestone v1.20
/priority important-soon

Sure, see #94774 @liggitt