Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Removes usage of the k8s-master label (version marker) #93626

Merged
merged 1 commit into from
Aug 27, 2020
Merged

[Cleanup] Removes usage of the k8s-master label (version marker) #93626

merged 1 commit into from
Aug 27, 2020

Conversation

vikkyomkar
Copy link
Contributor

@vikkyomkar vikkyomkar commented Aug 1, 2020 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
This PR does cleanup of not used "k8s-master" label

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#2237

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
No

kubeadm: remove support for the "ci/k8s-master" version label. This label has been removed in the Kubernetes CI release process and would no longer work in kubeadm. You can use the "ci/latest" version label instead. See kubernetes/test-infra#18517

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 1, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @vikkyomkar!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @vikkyomkar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 1, 2020
@k8s-ci-robot k8s-ci-robot requested review from detiber and kad August 1, 2020 10:29
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 1, 2020
@vikkyomkar
Copy link
Contributor Author

/assign @neolit123

@vikkyomkar
Copy link
Contributor Author

/cc @neolit123

@k8s-ci-robot k8s-ci-robot requested a review from neolit123 August 1, 2020 10:31
neolit123
neolit123 reviewed Aug 1, 2020
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vikkyomkar
the change looks good. thanks.

please have a look here:
https://raw.githubusercontent.com/kubernetes/kubernetes/master/.github/PULL_REQUEST_TEMPLATE.md

you seem to have deleted the release-note code block from the PR description / template.
please add it back and include the following text inside:

kubeadm: remove support for the "ci/k8s-master" version label. This label has been removed in the Kubernetes CI release process and would no longer work in kubeadm. You can use the "ci/latest" version label instead. See kubernetes/test-infra#18517

@neolit123
Copy link
Member

/ok-to-test
/priority important-longterm
/kind cleanup

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 1, 2020
@vikkyomkar
Copy link
Contributor Author

@vikkyomkar
the change looks good. thanks.

please have a look here:
https://raw.githubusercontent.com/kubernetes/kubernetes/master/.github/PULL_REQUEST_TEMPLATE.md

you seem to have deleted the release-note code block from the PR description / template.
please add it back and include the following text inside:

kubeadm: remove support for the "ci/k8s-master" version label. This label has been removed in the Kubernetes CI release process and would no longer work in kubeadm. You can use the "ci/latest" version label instead. See kubernetes/test-infra#18517

Done. Thanks @neolit123

@neolit123
Copy link
Member

neolit123 commented Aug 1, 2020 •
edited
Loading

it must be formatted exactly like:
https://raw.githubusercontent.com/kubernetes/kubernetes/master/.github/PULL_REQUEST_TEMPLATE.md

```release-note
kubeadm: remove support for the "ci/k8s-master" version label. This label has been removed in the Kubernetes CI release process and would no longer work in kubeadm. You can use the "ci/latest" version label instead. See kubernetes/test-infra#18517
```

once that is done this label will be removed:

do-not-merge/release-note-label-needed

@vikkyomkar
Copy link
Contributor Author

/test pull-kubernetes-verify

@neolit123
Copy link
Member

@vikkyomkar hi, did you see my comment above about fixing the release note?

/retest

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 4, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 4, 2020
@vikkyomkar
Copy link
Contributor Author

@neolit123 added the release note in required format. do-not-merge/release-note-label-needed label got removed now

@neolit123
Copy link
Member

/lgtm
/approve

thanks @vikkyomkar this PR should merge once code freeze for 1.19 ends.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, vikkyomkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2020
@neolit123
Copy link
Member

/milestone v1.20-phase-doc-cleanup

@k8s-ci-robot k8s-ci-robot added this to the v1.20-phase-doc-cleanup milestone Aug 27, 2020
@justaugustus
Copy link
Member

/test pull-kubernetes-e2e-kind-ipv6

@k8s-ci-robot k8s-ci-robot merged commit a39f9df into kubernetes:master Aug 27, 2020
@github-actions github-actions bot mentioned this pull request Sep 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@detiber detiber Awaiting requested review from detiber

@kad kad Awaiting requested review from kad

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

remove usage of the k8s-master label (version marker)
4 participants
@vikkyomkar @k8s-ci-robot @neolit123 @justaugustus