Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #82264: openstack: do not delete LB in case of security group #83737

Merged
merged 1 commit into from
Feb 8, 2020
Merged

Automated cherry pick of #82264: openstack: do not delete LB in case of security group #83737

merged 1 commit into from
Feb 8, 2020

Conversation

bashofmann
Copy link

Cherry pick of #82264 on release-1.16.

#82264: openstack: do not delete LB in case of security group

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot
Copy link
Contributor

Welcome @bashofmann!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Oct 10, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 10, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @bashofmann. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 10, 2019
@tpepper
Copy link
Member

tpepper commented Oct 10, 2019

/kind bug
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/bug Categorizes issue or PR as related to a bug. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 10, 2019
@bashofmann
Copy link
Author

/test pull-kubernetes-kubemark-e2e-gce-big

@bashofmann
Copy link
Author

/assign @FengyunPan2

@dims
Copy link
Member

dims commented Oct 16, 2019

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from dims October 16, 2019 13:45
This was referenced Dec 6, 2019
Closed
Merged
@tpepper
Copy link
Member

tpepper commented Dec 6, 2019

The set of peer cherry picks here:
1.14 #83740
1.15 #83738
1.16 #83737
are all in need of attention to get merged and today is the latest cherry pick deadline if you'd like to see them in the Dec. 2019 patch releases.

@NickrenREN
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bashofmann, NickrenREN

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2019
@justaugustus
Copy link
Member

/hold pending next patch release

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2019
@justaugustus
Copy link
Member

Looks like this job was recently added and hasn't yet run against this PR:
/test pull-kubernetes-e2e-gce-100-performance

@idealhack
Copy link
Member

This needs a /lgtm if you want to make it to the cherry-pick deadline on Friday.

@justaugustus
Copy link
Member

/hold all cherry picks are held until resolution of #86182 (tentative next week)

@feiskyer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2020
@feiskyer
Copy link
Member

@NickrenREN Do you think this cherry-pick is reasonable? Please apply "/lgtm" if yes.

@justaugustus
Copy link
Member

Today is the cherry pick deadline for the next patch release cycle.
If you intend to get this PR into this cycle, it must be approved by the relevant owners ASAP.

@NickrenREN
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2020
@justaugustus justaugustus added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 8, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 8, 2020
@justaugustus
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit a30889b into kubernetes:release-1.16 Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickrenREN NickrenREN Awaiting requested review from NickrenREN

Assignees

@NickrenREN NickrenREN

@FengyunPan2 FengyunPan2

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
10 participants
@bashofmann @k8s-ci-robot @tpepper @dims @NickrenREN @justaugustus @idealhack @feiskyer @FengyunPan2 @multi-io