Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl get does not count binaryData keys on ConfigMap #80827

Merged
merged 1 commit into from
Aug 4, 2019
Merged

kubectl get does not count binaryData keys on ConfigMap #80827

merged 1 commit into from
Aug 4, 2019

Conversation

smarterclayton
Copy link
Contributor

Running kubectl get against a configmap with only binary keys
returned a 0 for the number of keys which is incorrect.

/kind bug

kubectl get did not correctly count the number of binaryData keys when listing config maps.

@smarterclayton
kubectl get does not count binaryData keys on ConfigMap
bc6b735 
Running `kubectl get` against a configmap with only binary keys
returned a `0` for the number of keys which is incorrect.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 31, 2019
@k8s-ci-robot k8s-ci-robot requested review from rootfs and shiywang July 31, 2019 21:22
@smarterclayton
Copy link
Contributor Author

/assign @liggitt
/retest

@liggitt
Copy link
Member

liggitt commented Aug 1, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton smarterclayton added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 4, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 4, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit b81d30a into kubernetes:master Aug 4, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootfs rootfs Awaiting requested review from rootfs

@shiywang shiywang Awaiting requested review from shiywang

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
4 participants
@smarterclayton @liggitt @k8s-ci-robot @fejta-bot