feat: cleanup feature gates for KubeletPluginsWatcher #79310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
6 tasks
k8s-ci-robot
added
area/kubelet
sig/auth
mattjmcnaughton
approved these changes
Jun 23, 2019
k8s-ci-robot
added
the
lgtm
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: draveness, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
draveness
deleted the
feature/cleanup-KubeletPluginsWatcher-feature-gates
branch
rfranzke
added a commit
to rfranzke/gardener-extensions
that referenced
this pull request
Sep 19, 2019
The feature gate was already beta in 1.13 (least supported version of Alicloud/Packet which were using it) and enabled by default, it graduated to GA in 1.14. We never needed to explicitly enable it, we just have to make sure that it's not disabled. See kubernetes/kubernetes#79310
rfranzke
added a commit
to gardener-attic/gardener-extensions
that referenced
this pull request
Sep 19, 2019
The feature gate was already beta in 1.13 (least supported version of Alicloud/Packet which were using it) and enabled by default, it graduated to GA in 1.14. We never needed to explicitly enable it, we just have to make sure that it's not disabled. See kubernetes/kubernetes#79310
rfranzke
added a commit
to gardener-attic/gardener-extensions
that referenced
this pull request
Sep 19, 2019
The feature gate was already beta in 1.13 (least supported version of Alicloud/Packet which were using it) and enabled by default, it graduated to GA in 1.14. We never needed to explicitly enable it, we just have to make sure that it's not disabled. See kubernetes/kubernetes#79310
rfranzke
added a commit
to gardener-attic/gardener-extensions
that referenced
this pull request
Sep 20, 2019
The feature gate was already beta in 1.13 (least supported version of Alicloud/Packet which were using it) and enabled by default, it graduated to GA in 1.14. We never needed to explicitly enable it, we just have to make sure that it's not disabled. See kubernetes/kubernetes#79310
rfranzke
added a commit
to gardener-attic/gardener-extensions
that referenced
this pull request
Sep 20, 2019
The feature gate was already beta in 1.13 (least supported version of Alicloud/Packet which were using it) and enabled by default, it graduated to GA in 1.14. We never needed to explicitly enable it, we just have to make sure that it's not disabled. See kubernetes/kubernetes#79310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
What this PR does / why we need it:
KubeletPluginsWatcher has already graduated to GA two releases ago, we could remove it in release 1.16
Which issue(s) this PR fixes:
ref: #79308
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/priority important-soon
/assign @vikaschoudhary16