Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for configuring etcd hostname in the manifest #54403

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Allow for configuring etcd hostname in the manifest #54403

merged 1 commit into from
Oct 23, 2017

Conversation

wojtek-t
Copy link
Member 

Allow for configuring etcd hostname in the manifest

@wojtek-t wojtek-t added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 23, 2017
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 23, 2017
@mborsz
Copy link
Member

mborsz commented Oct 23, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2017
@wojtek-t
Copy link
Member Author

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, wojtek-t

Associated issue requirement bypassed by: wojtek-t

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 54400, 54403). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 060b4b8 into kubernetes:master Oct 23, 2017
@wojtek-t wojtek-t added this to the v1.8 milestone Oct 23, 2017
@wojtek-t wojtek-t mentioned this pull request Oct 23, 2017
Merged
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 23, 2017 •
edited
Loading

@wojtek-t: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-node-e2e 2fbe39f link /test pull-kubernetes-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-github-robot pushed a commit that referenced this pull request Oct 23, 2017
Merge pull request #54415 from wojtek-t/automated-cherry-pick-of-#544…
7848b19 
…03-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #54403 upstream release 1.8 

Cherrypick of #54403 to the 1.8 branch
#54403: Allow for configuring etcd hostname in the manifest
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.8" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@wojtek-t wojtek-t mentioned this pull request Oct 24, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Oct 24, 2017
Merge pull request #54475 from wojtek-t/automated-cherry-pick-of-#544…
7b9aded 
…03-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #54403 upstream release 1.7 

Cherrypick of #54403 to the 1.7 branch
#54403: Allow for configuring etcd hostname in the manifest
@wojtek-t wojtek-t deleted the dont_hardcode_etcd_hostname branch February 1, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mborsz mborsz mborsz approved these changes

Assignees

@mborsz mborsz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
5 participants
@wojtek-t @mborsz @k8s-github-robot @k8s-ci-robot @k8s-cherrypick-bot