Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log when node is initialized in cloud controller manager #53517

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Log when node is initialized in cloud controller manager #53517

merged 1 commit into from
Oct 11, 2017

Conversation

andrewsykim
Copy link
Member

What this PR does / why we need it:
Always logs when a node is successfully initialized and raises log level for adding node labels to new nodes. This is useful since the only way to know if CCM is working properly is to check for the taint node.cloudprovider.kubernetes.io/uninitialized.

Release note:

Log when node is successfully initialized by Cloud Controller Manager

cc @luxas @wlan0 @jhorwit2

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 6, 2017
@dims
Copy link
Member

dims commented Oct 6, 2017 •
edited
Loading

/retest

LGTM 👍

@jhorwit2
Copy link
Contributor

jhorwit2 commented Oct 6, 2017

lgtm

@andrewsykim
Copy link
Member Author

/test pull-kubernetes-unit

luxas
luxas approved these changes Oct 10, 2017
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, fix if you want
/lgtm

pkg/controller/cloud/node_controller.go
@@ -367,6 +367,8 @@ func (cnc *CloudNodeController) AddCloudNode(obj interface{}) {
utilruntime.HandleError(err)
return
}

glog.Infof("Successfully initialized node %s with cloud provider", node.Name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What v-level is this by default? Perhaps be consistent with V(2) here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's 0 by default, so it will always log. This was intentional :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, great!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2017
@luxas
Copy link
Member

luxas commented Oct 10, 2017

/retest

@wlan0
Copy link
Member

wlan0 commented Oct 11, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, luxas, wlan0

Associated issue requirement bypassed by: wlan0

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit efd6e6a into kubernetes:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas luxas approved these changes

Assignees

@wlan0 wlan0

@luxas luxas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@andrewsykim @dims @jhorwit2 @luxas @wlan0 @k8s-github-robot @k8s-ci-robot