Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup kubectl legacy server fallback #119410

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Cleanup kubectl legacy server fallback #119410

merged 1 commit into from
Sep 3, 2023
+1 −98

Conversation

Jefftree
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Should be removed after 1.9 is not supported and at v1.29 that should be plenty of releases.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Yes, kubectl will not support the "/swagger-2.0.0.pb-v1" endpoint that has been long deprecated

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 18, 2023
@Jefftree
Copy link
Member Author

(Not intended for 1.28 so feel free to ignore for now)
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 18, 2023
@Jefftree
Copy link
Member Author

Jefftree commented Sep 1, 2023

/assign @sttts

@sttts
Copy link
Contributor

sttts commented Sep 2, 2023

/lgtm
/approve

Please update the release note to fit into a release note document (without the "Yes, ..." :-) )

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c7b11ccbba9fcb1309800dcda966124d8639501b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2023
@pacoxu
Copy link
Member

pacoxu commented Sep 3, 2023

/test pull-kubernetes-e2e-gce

@pacoxu
Copy link
Member

pacoxu commented Sep 3, 2023

By the way, the release note is informal to me.

@k8s-ci-robot k8s-ci-robot merged commit ea3353d into kubernetes:master Sep 3, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 3, 2023
@Jefftree Jefftree deleted the kubectl-cleanup branch January 25, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
4 participants
@Jefftree @sttts @k8s-ci-robot @pacoxu