Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade etcd deps to v3.5.8 #117342

Merged
merged 3 commits into from
May 6, 2023

Conversation

kkkkun
Copy link
Member

@kkkkun kkkkun commented Apr 14, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # #117341

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @kkkkun. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 14, 2023
@kkkkun kkkkun mentioned this pull request Apr 14, 2023
4 tasks
@k8s-ci-robot k8s-ci-robot requested review from caesarxuchao, cheftako and a team April 14, 2023 08:37
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2023
@kkkkun kkkkun force-pushed the update-etcd-deps-3.5.8 branch from 8c0c6e2 to 5b1ddcb Compare April 18, 2023 05:47
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2023
@fedebongio
Copy link
Contributor

/assign @lavalamp @logicalhan @serathius
/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Apr 18, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 18, 2023
@kkkkun
Copy link
Member Author

kkkkun commented Apr 26, 2023

/release-note-none

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2023
@dims
Copy link
Member

dims commented May 3, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 3, 2023
@pacoxu
Copy link
Member

pacoxu commented May 5, 2023

/ok-to-test
/retest

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 5, 2023
@pacoxu
Copy link
Member

pacoxu commented May 5, 2023

/lgtm cancel

staging/src/k8s.io/apiserver/pkg/storage/etcd3/testserver/test_server.go:1: : # k8s.io/apiserver/pkg/storage/etcd3/testserver
pkg/storage/etcd3/testserver/test_server.go:69:6: cfg.LPUrls undefined (type *"go.etcd.io/etcd/server/v3/embed".Config has no field or method LPUrls)
pkg/storage/etcd3/testserver/test_server.go:70:6: cfg.APUrls undefined (type *"go.etcd.io/etcd/server/v3/embed".Config has no field or method APUrls)
pkg/storage/etcd3/testserver/test_server.go:71:6: cfg.LCUrls undefined (type *"go.etcd.io/etcd/server/v3/embed".Config has no field or method LCUrls)
pkg/storage/etcd3/testserver/test_server.go:72:6: cfg.ACUrls undefined (type *"go.etcd.io/etcd/server/v3/embed".Config has no field or method ACUrls) (typecheck)
/*

the CI needs to be fixed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2023
@k8s-ci-robot k8s-ci-robot requested a review from dims May 5, 2023 09:13
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 6, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kkkkun / name: Kun Zhang (36b760a, 334b6b35c988a82fa8bb05e2d72fd7c90e1fb2bf)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 6, 2023
@kkkkun kkkkun force-pushed the update-etcd-deps-3.5.8 branch from d26b699 to 334b6b3 Compare May 6, 2023 09:19
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 6, 2023
@kkkkun kkkkun force-pushed the update-etcd-deps-3.5.8 branch from 334b6b3 to 2ebc0cc Compare May 6, 2023 11:42
@dims
Copy link
Member

dims commented May 6, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fe60a9f278788352d2a52e906cf99adf3932948c

@k8s-ci-robot k8s-ci-robot merged commit c44b2ed into kubernetes:master May 6, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, kkkkun, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kkkkun kkkkun deleted the update-etcd-deps-3.5.8 branch May 8, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants