Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #112076: Revert "promote #112078

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Automated cherry pick of #112076: Revert "promote #112078

merged 1 commit into from
Aug 29, 2022

Conversation

rphillips
Copy link
Member

@rphillips rphillips commented Aug 26, 2022 •
edited by liggitt
Loading

Cherry pick of #112076 on release-1.25.

#112076: Revert "promote

For details on the cherry pick process, see the cherry pick requests page.

Fix a 1.25 regression updating mounted configmaps when the LocalStorageCapacityIsolationFSQuotaMonitoring feature is enabled. LocalStorageCapacityIsolationFSQuotaMonitoring feature gate is demoted back to Alpha.

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 26, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test labels Aug 26, 2022
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 26, 2022
@liggitt
Copy link
Member

liggitt commented Aug 27, 2022

/lgtm
/approve
/kind regression

@k8s-ci-robot k8s-ci-robot added kind/regression Categorizes issue or PR as related to a regression from a prior release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 27, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 27, 2022
@rphillips
Copy link
Member Author

/retest

@rphillips
Copy link
Member Author

/assign @kubernetes/release-managers

@rphillips
Copy link
Member Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 27, 2022
@dims
Copy link
Member

dims commented Aug 27, 2022

/cc @palnabarun

@pacoxu
Copy link
Member

pacoxu commented Aug 29, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Aug 29, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 29, 2022
saschagrunert
saschagrunert approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saschagrunert saschagrunert added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Aug 29, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, rphillips, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2b09991 into kubernetes:release-1.25 Aug 29, 2022
@kikisdeliveryservice kikisdeliveryservice mentioned this pull request Aug 29, 2022
Merged
kikisdeliveryservice added a commit to kikisdeliveryservice/k8s-website that referenced this pull request Aug 29, 2022
@kikisdeliveryservice
Revert: promote LocalStorageCapacityIsolationFSQuotaMonitoring to beta
96a8fde 
This feature has been reverted to alpha in master and 1.25.
Related-to: kubernetes/kubernetes#112076
Related-to: kubernetes/kubernetes#112078
Related-to: kubernetes/enhancements#1029
@kikisdeliveryservice kikisdeliveryservice mentioned this pull request Aug 29, 2022
Merged
kikisdeliveryservice added a commit to kikisdeliveryservice/k8s-website that referenced this pull request Aug 30, 2022
@kikisdeliveryservice
Revert: promote LocalStorageCapacityIsolationFSQuotaMonitoring to beta
04f9794 
This feature has been reverted to alpha in master and 1.25.
Related-to: kubernetes/kubernetes#112076
Related-to: kubernetes/kubernetes#112078
Related-to: kubernetes/enhancements#1029
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 9, 2023
@liggitt liggitt added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 27, 2023
@liggitt liggitt mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@saschagrunert saschagrunert

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
6 participants
@rphillips @liggitt @dims @pacoxu @k8s-ci-robot @saschagrunert