Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: list pod err after an pod evicted #110425

Merged
merged 1 commit into from
Jun 22, 2022
Merged

fix: list pod err after an pod evicted #110425

merged 1 commit into from
Jun 22, 2022

Conversation

LY-today
Copy link

@LY-today LY-today commented Jun 7, 2022 •
edited by liggitt
Loading

Signed-off-by: LY-today [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

After I evicted an pod, I performed the operation of the full list instance, but found something that did not meet expectations

client-go: fixed an error in the fake client when submitting create API requests to subresources like pods/eviction

cause subsequent programs to fail to function properly

Which issue(s) this PR fixes:

Fixes #110424

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 7, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 7, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: LY-today (b3215d516e22edeb43807fbd9b968e2bf019e423)

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 7, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @LY-today!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 7, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @LY-today. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 7, 2022
@k8s-ci-robot k8s-ci-robot requested review from lavalamp and sttts June 7, 2022 12:32
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 7, 2022
@fedebongio
Copy link
Contributor

/assign @yliaog
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 7, 2022
@mangk
Copy link

mangk commented Jun 8, 2022

I also encountered this problem, this method does solve my problem

@pacoxu
Copy link
Member

pacoxu commented Jun 8, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2022
@pacoxu
Copy link
Member

pacoxu commented Jun 8, 2022

/cc @caesarxuchao @roycaihw

@endocrimes endocrimes mentioned this pull request Jun 8, 2022
Closed
@k8s-ci-robot k8s-ci-robot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Jun 15, 2022
@LY-today
Copy link
Author

@liggitt hi,The tide process seems to be stuck, what information do I need to add to move the process forward?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 22, 2022
liggitt
liggitt reviewed Jun 22, 2022
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple last small comments, and squash to a single commit, then lgtm

staging/src/k8s.io/client-go/testing/fixture.go Outdated
@@ -18,13 +18,12 @@ package testing

import (
"fmt"
jsonpatch "github.com/evanphx/json-patch"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this import back to its own line, distinct from stdlib imports and from k8s imports

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

received, changes have been made

staging/src/k8s.io/client-go/testing/fixture.go Show resolved Hide resolved
@liggitt
Copy link
Member

liggitt commented Jun 22, 2022

changes look good, please squash to a single commit

@LY-today LY-today force-pushed the fake-evict-list-err branch from c575b92 to 20be911 Compare June 22, 2022 15:07
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Jun 22, 2022
@LY-today
Copy link
Author

更改看起来不错，请压缩到单个提交

changes look good, please squash to a single commit

received, already rebase

@LY-today LY-today force-pushed the fake-evict-list-err branch from 1865c2f to f299494 Compare June 22, 2022 15:30
@liggitt
Copy link
Member

liggitt commented Jun 22, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, LY-today

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1d81106 into kubernetes:master Jun 22, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 22, 2022
@aldor007 aldor007 mentioned this pull request Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu left review comments

@harshanarayana harshanarayana harshanarayana left review comments

@liggitt liggitt liggitt left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

@sttts sttts Awaiting requested review from sttts

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees

@liggitt liggitt

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

FakeClient: list pod err after an pod evicted
8 participants
@LY-today @k8s-ci-robot @fedebongio @mangk @pacoxu @liggitt @harshanarayana @yliaog