-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PodSecurity] Warn when adding PSA labels to exempt namespaces #109680
Conversation
Please note that we're already in Test Freeze for the |
@tallclair: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
staging/src/k8s.io/pod-security-admission/admission/admission.go
Outdated
Show resolved
Hide resolved
/retest |
1 similar comment
/retest |
staging/src/k8s.io/pod-security-admission/admission/admission.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/pod-security-admission/admission/admission.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/pod-security-admission/admission/admission.go
Outdated
Show resolved
Hide resolved
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, tallclair The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Trivial test fix, adding back lgtm. |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Return a warning when adding or updating a non-privileged Pod Security label on an exempted namespace.
The exempt audit annotation is no longer included on update namespace requests on exempt namespaces. It's usage was inconsistent (didn't apply to create), and is less relevant to namespace operations (we're not bypassing the policy).
Which issue(s) this PR fixes:
Fixes #109549
Special notes for your reviewer:
Does this PR introduce a user-facing change?
/sig auth
/milestone v1.25
/assign @liggitt