-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shell completion for new --subresource flag #109070
Add shell completion for new --subresource flag #109070
Conversation
Signed-off-by: Marc Khouzam <[email protected]>
@marckhouzam: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Not very important but still applicable |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Not very important but since it's only a 3-line change maybe @brianpursley has time to take a look? |
Sure I'll take a look... /remove-lifecycle rotten |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianpursley, marckhouzam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/sig cli
What this PR does / why we need it:
Adds shell completion for the new
--subresource
flag.#99556 added the
--subresource
flag which accepts a specific set of values, mostlystatus
andscale
.The help message of the flag is clear on what values can be accepted.
I feel that having the shell completion provide those choices can help the user even further.
Currently, if users try to complete the values of the
--subresource
flag, they will get files being suggested.Currently:
With PR:
Does this PR introduce a user-facing change?
/cc @nikhita