Next step in CSI migration for openstack

[dims]

Following up on #98538 that went into k8s v1.21

We remove usage of features.CSIMigrationOpenStack from the code base and set a timer to delete features.CSIMigrationOpenStack in 1.26.

Signed-off-by: Davanum Srinivas [email protected]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

OpenStack Cinder CSI migration is now GA and switched on by default, Cinder CSI driver must be installed on clusters on OpenStack for Cinder volumes to work (has been since v1.21). 

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

@dims: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/features/OWNERS [dims]
• pkg/scheduler/OWNERS [dims]
• pkg/volume/OWNERS [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dims]

/assign @xing-yang @jsafrane @gnufied

[dims]

/hold

[xing-yang]

@dims Do you know if there's an enhancement issue for CSI migration for OpenStack? I couldn't find it.

[Jiawei0227]

/retest

[Jiawei0227]

@dims Do you know if there's an enhancement issue for CSI migration for OpenStack? I couldn't find it.

PR for the KEP is here: kubernetes/enhancements#3124

If folks REALLY need the in-tree, they will now have to switch OFF features.InTreePluginOpenStackUnregister as with this PR we switch off the in-tree registration.

How will folks use in-tree if they turn off features.InTreePluginOpenStackUnregister?

[xing-yang]

If folks REALLY need the in-tree, they will now have to switch OFF features.InTreePluginOpenStackUnregister as with this PR we switch off the in-tree registration.

How will folks use in-tree if they turn off features.InTreePluginOpenStackUnregister?

I think the change to features.InTreePluginOpenStackUnregister was in the earlier version of the PR but it is not in this latest version of the PR any more. @dims Can you please update the PR description to reflect this change?

[dims]

@xing-yang Done!

[xing-yang]

/lgtm

[dims]

/hold cancel

thanks @xing-yang

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest