Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go1.16] Update to go1.16.8 #104906

Merged
merged 1 commit into from
Sep 15, 2021
Merged

[go1.16] Update to go1.16.8 #104906

merged 1 commit into from
Sep 15, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Sep 10, 2021 •
edited
Loading

What type of PR is this?

/kind feature
/area dependency release-eng security

What this PR does / why we need it:

Update Kubernetes to go1.16.8 for release 1.22 branch

Tracking issue: kubernetes/release#2238

/assign @dims @liggitt @justaugustus
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes is now built with Golang 1.16.8

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Sep 10, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 10, 2021
@cpanato
Copy link
Member Author

cpanato commented Sep 10, 2021

/assign @dims @liggitt @justaugustus
cc: @kubernetes/release-engineering

@cpanato cpanato changed the title Automated cherry pick of #104905: Update to go1.16.8 [go1.16] Update to go1.16.8 Sep 10, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 10, 2021
@cpanato cpanato mentioned this pull request Sep 10, 2021
Closed
26 tasks
@cpanato
Update to go1.16.8
6562be2 
Signed-off-by: Carlos Panato <[email protected]>
@cpanato cpanato force-pushed the automated-cherry-pick-of-#104905-upstream-release-1.21 branch from 3b89fc3 to 6562be2 Compare September 10, 2021 13:45
@dims
Copy link
Member

dims commented Sep 14, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2021
@cpanato
Copy link
Member Author

cpanato commented Sep 14, 2021

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 14, 2021
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2021
@justaugustus justaugustus added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 14, 2021
@justaugustus
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2021
@justaugustus justaugustus removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 14, 2021
@justaugustus
Copy link
Member

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 14, 2021
@justaugustus
Copy link
Member

The bots are having one today...
/area dependency release-eng security

@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes area/security labels Sep 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit 99c0097 into kubernetes:release-1.21 Sep 15, 2021
@cpanato cpanato deleted the automated-cherry-pick-of-#104905-upstream-release-1.21 branch September 15, 2021 12:16
This was referenced Sep 15, 2021
Merged
Merged
@justaugustus
Copy link
Member

hmm good call!, looks like we need to build one image for 1.21

@justaugustus summoning you here to double-check this, if that is needed I will work on that right away

The image content will effectively be the same, but yes, let's do this for consistency with the branch name/release version (as that was the reason for the tag nomenclature change).

@cpanato
Copy link
Member Author

cpanato commented Sep 15, 2021

hmm good call!, looks like we need to build one image for 1.21
@justaugustus summoning you here to double-check this, if that is needed I will work on that right away

The image content will effectively be the same, but yes, let's do this for consistency with the branch name/release version (as that was the reason for the tag nomenclature change).

will start on those now! and will do the same for 1.19/1.20 as well

@justaugustus
Copy link
Member

will do the same for 1.19/1.20 as well

I'd hold off on 1.19/1.20. They're using an unsupported version of Golang (go1.15.15), so I don't expect updates to them anytime soon.

This was referenced Sep 15, 2021
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan Awaiting requested review from hasheddan

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@dims dims

@justaugustus justaugustus

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/security area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
5 participants
@cpanato @dims @justaugustus @k8s-ci-robot @liggitt