Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runc 1.2.0 (and potentially earlier) is incompatible with golang 1.22 #124168

Closed
haircommander opened this issue Apr 3, 2024 · 6 comments
Closed
Labels
kind/support Categorizes issue or PR as a support question. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/release Categorizes an issue or PR as relevant to SIG Release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@haircommander
Copy link
Contributor

What happened?

cross posting here for visibility opencontainers/runc#4233

What did you expect to happen?

the version of golang we use to build kube is compatible with newer versions

How can we reproduce it (as minimally and precisely as possible)?

attempt to build runc with 1.22, or kube with 1.21
xref cri-o/cri-o#7956

Anything else we need to know?

No response

Kubernetes version

$ kubectl version
# paste output here
v1.30

Cloud provider

all

OS version

only certain glibc versions

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

@haircommander haircommander added the kind/bug Categorizes issue or PR as related to a bug. label Apr 3, 2024
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 3, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert saschagrunert added sig/release Categorizes an issue or PR as relevant to SIG Release. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Apr 3, 2024
@k8s-ci-robot k8s-ci-robot removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 3, 2024
@saschagrunert saschagrunert added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 3, 2024
@liggitt
Copy link
Member

liggitt commented Apr 3, 2024

/remove-kind bug
/kind support

Latest kubernetes builds with latest go (unless there's a Kubernetes-impacting regression that requires us to stay on an earlier go version), if you need to build with go1.21 in the short-term, the Kubernetes 1.29 libraries are usable and still patched / maintained.

@k8s-ci-robot k8s-ci-robot added kind/support Categorizes issue or PR as a support question. and removed kind/bug Categorizes issue or PR as related to a bug. labels Apr 3, 2024
@liggitt
Copy link
Member

liggitt commented Apr 3, 2024

/close

@k8s-ci-robot
Copy link
Contributor

@liggitt: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Contributor Author

note: this will affect users who use the same go to build kubernetes and runc. It's possible even older versions of runc are incompatible with the changes in go 1.22. There could be kubernetes regressions when it comes to calling runc

@liggitt
Copy link
Member

liggitt commented Apr 3, 2024

kubernetes calls runc as a binary, not as a library, so the code in question is not part of the kubernetes build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/support Categorizes issue or PR as a support question. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/release Categorizes an issue or PR as relevant to SIG Release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants