Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use k8s-release-dev instead of kubernetes-release-dev #2528

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 17, 2021

this was a straight search-replace rather than attempting to converge
toward dl.k8s.io because way too much of this is stale. I tried editing
to update stale info at first, but someone who knows the state of things
needs to do this.

e.g. many of the uris in here are already dead, let alone things like
/bazel and /ci-cross not existing in gs://k8s-release-dev

This is part of kubernetes/k8s.io#2318

this was a straight search-replace rather than attempting to converge
toward dl.k8s.io because way too much of this is stale. I tried editing
to update stale info at first, but someone who knows the state of things
needs to do this.

e.g. many of the uris in here are already dead, let alone things like
/bazel and /ci-cross not existing in gs://k8s-release-dev
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 17, 2021
@k8s-ci-robot k8s-ci-robot requested review from pacoxu and yagonobre July 17, 2021 01:36
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 17, 2021
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks,

logged this issue for tracking:
#2529

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2021
@neolit123 neolit123 added kind/documentation Categorizes issue or PR as related to documentation. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 17, 2021
@neolit123 neolit123 added this to the v1.22 milestone Jul 17, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 19, 2021

@neolit123 just double-checking, was there a reason you removed the approved label?

@neolit123
Copy link
Member

neolit123 commented Jul 19, 2021

@neolit123 just double-checking, was there a reason you removed the approved label?

no, this has happened for me before, so either there is a github bug, or i'm unchecking the label when adding a new one (i don't think so).

@neolit123 neolit123 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 85bb93f into kubernetes:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants