Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc fixes to kind-kinder.md #2126

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Doc fixes to kind-kinder.md #2126

merged 1 commit into from
Apr 30, 2020

Conversation

prasadkatti
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 30, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @prasadkatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 30, 2020
@k8s-ci-robot k8s-ci-robot requested review from kad and timothysc April 30, 2020 21:31
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Apr 30, 2020
neolit123
neolit123 reviewed Apr 30, 2020
View reviewed changes
kinder/doc/kind-kinder.md Outdated
Kinder provider an UX designed for helping kubeadm contributors and for kubeadm E2E tests;
Only few of the [kind](https://github.com/kubernetes-sigs/kind) commands will be available in kinder,
because they are useful for the use cases targeted by kinder.
Kinder provides an UX designed for helping kubeadm contributors and for kubeadm E2E tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a UX since UX is pronounced as You-Ex.

neolit123
neolit123 reviewed Apr 30, 2020
View reviewed changes
kinder/doc/kind-kinder.md Outdated
Only few of the [kind](https://github.com/kubernetes-sigs/kind) commands will be available in kinder,
because they are useful for the use cases targeted by kinder.
Kinder provides an UX designed for helping kubeadm contributors and for kubeadm E2E tests.
Only the subset of the [kind](https://github.com/kubernetes-sigs/kind) commands which are useful for the targeted use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Only a subset..."

neolit123
neolit123 reviewed Apr 30, 2020
View reviewed changes
kinder/doc/kind-kinder.md Outdated
because they are useful for the use cases targeted by kinder.
Kinder provides an UX designed for helping kubeadm contributors and for kubeadm E2E tests.
Only the subset of the [kind](https://github.com/kubernetes-sigs/kind) commands which are useful for the targeted use
cases is available to kinder.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...in kinder"

neolit123
neolit123 reviewed Apr 30, 2020
View reviewed changes
kinder/doc/kind-kinder.md
- Generate load balancer config
- Creating machines running as containers
- Generating kubeadm config
- Generating load balancer config
Copy link
Member

@neolit123 neolit123 Apr 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is present continuous tense really needed for the above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few lines up I changed it to present continuous tense because it feels more natural. So I thought I should keep it consistent. But I can switch this back to how it was before if you think that makes more sense.

Copy link
Member

@neolit123 neolit123 Apr 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, SGTM. let's leave the new change.

neolit123
neolit123 reviewed Apr 30, 2020
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/area kinder
/priority backlog

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. area/kinder Issues to track work in the kinder tool priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 30, 2020
@neolit123
Copy link
Member

thanks
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, prasadkatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 30, 2020
@prasadkatti
Copy link
Contributor Author

prasadkatti commented Apr 30, 2020 •
edited
Loading

/retest

The second worker failed to join the cluster and it timed out here -
kinder-pull-worker-2:$ waiting for Node to become Ready (timeout 5m0s)

@k8s-ci-robot k8s-ci-robot merged commit 2c56815 into kubernetes:master Apr 30, 2020
@prasadkatti prasadkatti deleted the kinder_docs branch April 30, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@kad kad Awaiting requested review from kad

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kinder Issues to track work in the kinder tool cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prasadkatti @k8s-ci-robot @neolit123