Create a KEP for the kubeadm-kubelet integration #851
Assignees
Labels
area/releasing
kind/documentation
Categorizes issue or PR as related to documentation.
priority/important-longterm
Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Comments
luxas
added
priority/important-longterm
|
Or even just:
kubeadm --config path
If path=dir, Kubeadm should be able to figure out which object is for which
component based on group/kind. Same for path=yaml file with multiple
objects in it.
…On Wed, May 23, 2018, 12:06 AM Lucas Käldström ***@***.***> wrote:
Create a KEP for #822 <#822>
cc @mtaufen <https://github.com/mtaufen> @timothysc
<https://github.com/timothysc>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#851>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA3JwSpo8YpOzB7URZuKQUOsEEefxtR3ks5t1QqAgaJpZM4UJ4ce>
.
|
|
Or we could just say our config file can look like this: apiVersion: kubeadm.k8s.io/v1beta1
kind: InitConfiguration
...
---
apiVersion: kubelet.config.k8s.io/v1beta1
kind: KubeletConfiguration
...
---
apiVersion: kubeproxy.config.k8s.io/v1beta1
kind: KubeProxyConfiguration
... |
|
Also xref related: #847 |
|
I'm not sure I'd force everything to be in a single file. Option to slurp a dir with arbitrary files might be better. |
|
Okay, without forcing, does it make sense to have as an option to you? |
|
Yes, allowing multiple objects in a single file makes sense to me. |
|
+1 to
|
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this issue
Jun 6, 2018
Automatic merge from submit-queue (batch tested with PRs 64009, 64780, 64354, 64727, 63650). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubeadm: Update the dropin for the kubelet in v1.11 **What this PR does / why we need it**: One of the final pieces of kubernetes/kubeadm#851, kubernetes/kubeadm#847 and kubernetes/kubeadm#822 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: (partially) Fixes kubernetes/kubeadm#822 **Special notes for your reviewer**: Please check whether this release note makes sense to you. **Release note**: ```release-note [action required] The structure of the kubelet dropin in the kubeadm deb package has changed significantly. Instead of hard-coding the parameters for the kubelet in the dropin, a structured configuration file for the kubelet is used, and is expected to be present in `/var/lib/kubelet/config.yaml`. For runtime-detected, instance-specific configuration values, a environment file with dynamically-generated flags at `kubeadm init` or `kubeadm join` run time is used. Finally, if the user wants to override something specific for the kubelet that can't be done via the kubeadm Configuration file (which is preferred), they might add flags to the `KUBELET_EXTRA_ARGS` environment variable in either `/etc/default/kubelet` or `/etc/sysconfig/kubelet`, depending on the system you're running on. ``` @kubernetes/sig-cluster-lifecycle-pr-reviews
|
This is already in, so closing imo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Create a KEP for #822
We also need to finally decide whether to embed the kubelet ComponentConfiguration in our config or if we should just do
kubeadm init --config kubeadm.yaml --kubelet-config kubelet.yaml --kube-proxy-config kubeproxy.yaml ...for all components as the end goal.cc @mtaufen @timothysc
The text was updated successfully, but these errors were encountered: