fix make test units with cgo #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Merged
|
Yes I am aware of this, the only reason why we have this I entirely agree with this change, and have always run tests myself. Maybe @piosz can comment on the parts of the |
|
/ping @piosz WDYT. |
|
LGTM |
|
Friendly ping @brancz @vdavidoff |
while1malloc0
pushed a commit
to while1malloc0/kube-state-metrics
that referenced
this pull request
Jul 2, 2018
fix make test units with cgo
simonpasquier
pushed a commit
to simonpasquier/kube-state-metrics
that referenced
this pull request
Dec 2, 2022
OCPBUGS-4089: cherry-pick, do not expose ingress path metric when service is nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go test -racecan not be run with cgo disabled. This will resultmake test-unitfailed.FYI:
/cc @brancz @vdavidoff
This change is