added termination reason metric #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
We need to be careful with the amount of metrics we add especially around pods and containers, as they grow linearly with the other objects. This seems like extremely useful information though so I think it's a valuable addition. We're currently in the last steps of releasing Code wise this lgtm 👍 thanks! |
|
Nice, once v1.1.0 is out I'll ping you again here then 🍻 |
|
@brancz ping |
|
Thanks for the ping! |
|
Thanks :D |
while1malloc0
pushed a commit
to while1malloc0/kube-state-metrics
that referenced
this pull request
Jul 2, 2018
added termination reason metric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
very much like #256, but for containers that were terminated.
It should be useful to detect apps that are being constantly OOMKilled, for example.
I got the possible reasons from kubernetes codebase:
https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/dockershim/docker_container.go#L328-L361
+cc @brancz
This change is