-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new metric kube_job_status_suspended #2542
feat: Add new metric kube_job_status_suspended #2542
Conversation
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @Indresh2410! |
We can follow other metrics to have only 2 labels: job_name and namespace name. |
Thanks @CatherineF-dev . Have addressed them. Can you please check once? |
/lgtm |
@CatherineF-dev have updated doc. Because of which label got removed. Can you please check once again. SFIC |
/lgtm |
Can you rebase this on latest main branch? Thanks! |
1e8b1dc
to
b2c8fa7
Compare
Have rebased @mrueg . Can you please check once? |
@Indresh2410 it looks like the newline is missing in the doc. Could you add it? |
Thanks @mrueg . Have addressed it. Can you please check once? |
/lgtm Thanks for your contribution! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CatherineF-dev, Indresh2410, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Kubernetes has released a new feature which can suspend a job
https://kubernetes.io/docs/concepts/workloads/controllers/job/#suspending-a-job
Emit metrics if the job is suspended
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Increases
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged)Fixes # #2511