fix: big memory overflow

[leiwingqueen]

What this PR does / why we need it:

I have a machine with big memory (about 10000TB size) will get a negative number in metrics. I found that the node metrics value do the convert as float64(val.MilliValue()) / 1000 before return. It may overflow when the value is bigger than maxInt64/1000.

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)

does not change cardinality

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #2541

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: leiwingqueen / name: leiwingqueen (f94ef65, 37f10f0, e5eb2ed, 31f7931, 7980f03, 2c34676)
• ✅ login: mrueg / name: Manuel Rüger (c67f02f)

[k8s-ci-robot]

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

Welcome @leiwingqueen!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[mrueg]

Checking the code for MilliValue, it seems like we're using it in other occasions as well. Do you mind moving the convertValueToFloat64 func into internal/store/utils.go and apply them there as well?

./internal/store/horizontalpodautoscaler.go:                                    metricMap[value] = float64(metricTarget.Value.MilliValue()) / 1000
./internal/store/horizontalpodautoscaler.go:                                    metricMap[average] = float64(metricTarget.AverageValue.MilliValue()) / 1000
./internal/store/horizontalpodautoscaler.go:                                    metricMap[value] = float64(currentMetric.Value.MilliValue()) / 1000
./internal/store/horizontalpodautoscaler.go:                                    metricMap[average] = float64(currentMetric.AverageValue.MilliValue()) / 1000
./internal/store/node.go:                                               Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                               Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                               Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                                       Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                                       Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                                       Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                               Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                               Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                               Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                                       Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                                       Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                                       Value: float64(val.MilliValue()) / 1000,
./internal/store/pod.go:                                                        Value:       float64(val.MilliValue()) / 1000,
./internal/store/pod.go:                                                        Value:       float64(val.MilliValue()) / 1000,
./internal/store/pod.go:                                                        Value:       float64(val.MilliValue()) / 1000,
./internal/store/pod.go:                                                        Value:       float64(val.MilliValue()) / 1000,
./internal/store/pod.go:                                                        Value: float64(val.MilliValue()) / 1000,
./internal/store/limitrange.go:                                                 Value:       float64(min.MilliValue()) / 1000,
./internal/store/limitrange.go:                                                 Value:       float64(max.MilliValue()) / 1000,
./internal/store/limitrange.go:                                                 Value:       float64(df.MilliValue()) / 1000,
./internal/store/limitrange.go:                                                 Value:       float64(dfR.MilliValue()) / 1000,
./internal/store/limitrange.go:                                                 Value:       float64(mLR.MilliValue()) / 1000,
./internal/store/resourcequota.go:                                              Value:       float64(qty.MilliValue()) / 1000,
./internal/store/resourcequota.go:                                              Value:       float64(qty.MilliValue()) / 1000,

[mrueg]

accidentally closed this, apologies.

[leiwingqueen]

Checking the code for MilliValue, it seems like we're using it in other occasions as well. Do you mind moving the convertValueToFloat64 func into internal/store/utils.go and apply them there as well?

./internal/store/horizontalpodautoscaler.go:                                    metricMap[value] = float64(metricTarget.Value.MilliValue()) / 1000
./internal/store/horizontalpodautoscaler.go:                                    metricMap[average] = float64(metricTarget.AverageValue.MilliValue()) / 1000
./internal/store/horizontalpodautoscaler.go:                                    metricMap[value] = float64(currentMetric.Value.MilliValue()) / 1000
./internal/store/horizontalpodautoscaler.go:                                    metricMap[average] = float64(currentMetric.AverageValue.MilliValue()) / 1000
./internal/store/node.go:                                               Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                               Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                               Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                                       Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                                       Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                                       Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                               Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                               Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                               Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                                       Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                                       Value: float64(val.MilliValue()) / 1000,
./internal/store/node.go:                                                       Value: float64(val.MilliValue()) / 1000,
./internal/store/pod.go:                                                        Value:       float64(val.MilliValue()) / 1000,
./internal/store/pod.go:                                                        Value:       float64(val.MilliValue()) / 1000,
./internal/store/pod.go:                                                        Value:       float64(val.MilliValue()) / 1000,
./internal/store/pod.go:                                                        Value:       float64(val.MilliValue()) / 1000,
./internal/store/pod.go:                                                        Value: float64(val.MilliValue()) / 1000,
./internal/store/limitrange.go:                                                 Value:       float64(min.MilliValue()) / 1000,
./internal/store/limitrange.go:                                                 Value:       float64(max.MilliValue()) / 1000,
./internal/store/limitrange.go:                                                 Value:       float64(df.MilliValue()) / 1000,
./internal/store/limitrange.go:                                                 Value:       float64(dfR.MilliValue()) / 1000,
./internal/store/limitrange.go:                                                 Value:       float64(mLR.MilliValue()) / 1000,
./internal/store/resourcequota.go:                                              Value:       float64(qty.MilliValue()) / 1000,
./internal/store/resourcequota.go:                                              Value:       float64(qty.MilliValue()) / 1000,

copy that

[CatherineF-dev]

Could we remove if-else and use float64(q.MilliValue() / 1000)?

[leiwingqueen]

may be not. q.MilliValue() will cause overflow when q.Value() is larger than maxInt64/1000. for example, 1000TB will return a negative number.

[CatherineF-dev]

Ack.

[CatherineF-dev]

/lgtm

[leiwingqueen]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CatherineF-dev, leiwingqueen Once this PR has been reviewed and has the lgtm label, please assign rexagod for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

/assign @rexagod

[leiwingqueen]

/assign @mrueg

[mrueg]

I updated the comment in the convertValueToFloat64 func to make it clear that it's checking for an overflow.

/lgtm

Thanks for your contribution!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CatherineF-dev, leiwingqueen, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mrueg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment