feat: Move endpoint ports into address metric #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
k8s-ci-robot
added
approved
mrueg
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Do we need to add this breaking change into release notes later? |
Yes, I'll make sure it's part of the changelog of the next release. |
|
/lgtm |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
@rexagod @dgrisonnet are you okay with this? Then I'll start adjusting the tests. |
dgrisonnet
reviewed
Oct 15, 2024
k8s-ci-robot
removed
the
lgtm
|
What was the preference for empty labels again? Omit them? e.g. port_name in this metric: We keep it in kube_endpoint_ports. |
k8s-ci-robot
added
size/L
|
Thanks! This is now ready for review. |
mrueg
changed the title
This marks kube_endpoint_ports as deprecated
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
/lgtm Thank you for all the great work, not just this PR, but everything! 🙇 |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CatherineF-dev, mrueg, rexagod The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
philipgough
added a commit
to philipgough/kube-prometheus
that referenced
this pull request
Nov 12, 2024
philipgough
added a commit
to prometheus-operator/kube-prometheus
that referenced
this pull request
Nov 12, 2024
* [bot] [main] Automated version update * Drops kube_endpoint_ports metric from KSM due to kubernetes/kube-state-metrics#2503 --------- Co-authored-by: Prometheus Operator Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This moves the labels from kube_endpoint_ports int kube_endpoint_address (as the subset in an endpoint can contain multiple addresses and ports that need to be linked together)
This change also marks kube_endpoint_ports as deprecated
Fixes #2408
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
This change creates
ports * addressesmetrics instead ofports + addressesmetrics.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2408
I will fix tests later once we have an agreement to move forward like this.