move default image registry to quay #246

andyxning · 2017-08-28T13:36:46Z

This PR will move kube-state-metrics image registry from gcr.io to quay.io.

This is mainly because there are some times(#224 comment, #88 comment) the latest image can not be pushed to gcr.io timely. Users may be delayed to use the latest kube-state-metrics for this reason. A better way was to use quay.io as the docker registry as @brancz should be able to push the latest image when a new kube-state-metrics is released.

/cc @brancz @loburm @fabxc @piosz

This change is

brancz · 2017-08-28T13:47:28Z

Makefile

@@ -35,7 +35,7 @@ container: build
 	docker build -t ${REGISTRY}/kube-state-metrics:$(TAG) .

 push: container
-	gcloud docker -- push ${REGISTRY}/kube-state-metrics:$(TAG)


As I don't use this make target, we can leave this for the google people as a help, as the image should still be published on gcr.

brancz · 2017-08-28T13:48:34Z

README.md

@@ -27,7 +27,7 @@ Currently, `client-go` is in version `v4.0.0-beta.0`.

 ## Container Image

-The latest container image can be found at `gcr.io/google_containers/kube-state-metrics:v0.5.0`.
+The latest container image can be found at `quay.io/coreos/kube-state-metrics:v1.0.1`.


Let's enumerate both container image repositories here, but write a note, that the gcr image is only maintained on best effort as it requires external action from Google employees as no Google employee actively works on kube-state-metrics.

done. PTAL.

brancz · 2017-08-28T13:50:54Z

I'm fine with doing this, but we should still try to maintain the gcr repository, as people have expressed their interest in the gcr image before.

@piosz last time I opened a PR like this we closed it, as we said this process will be opened up to non google employees, what is the state on this, as we have trouble regarding this on every release?

andyxning · 2017-08-28T13:58:48Z

@piosz @loburm This situation also have been encountered many times in the maintenance of heapster.

piosz · 2017-08-28T20:04:15Z

@kubernetes/sig-release-feature-requests could you please address the questions above?
@bgrant0607 is this ok to have official Kubernetes images in a different repo than gcr.io/google_containers ?

piosz · 2017-08-28T20:05:54Z

... and apologies for not doing great job here, but we only have a limited capacity. I agree that lack of access to the official Docker repository for non-googlers is painful.

piosz · 2017-08-28T20:06:17Z

/assign @piosz

andyxning · 2017-09-05T13:20:48Z

Any updates?

bgrant0607 · 2017-09-05T14:32:14Z

@andyxning @brancz

In one of the previously cited PRs I see a comment "I pinged some Googlers". Who and how? Was the release team notified?

What is the release process for kube-state-metrics? At a glance, I didn't see this in the README and didn't see other obvious docs in the top level dir. Our repo template suggests RELEASE.md.

The general issue for solving this is:
kubernetes/release#281

How large is the image?

Also, how do users know which Kubernetes releases a given release of kube-state-metrics will work with?

brancz · 2017-09-05T14:53:44Z

Whenever we want to release a version of kube-state-metrics, I ping @piosz and @loburm as they are active members of sig-instrumentation and kube-state-metrics is owned by sig-instrumentation.

Previous attempts (that I could quickly find) around this include:

We picked up development from the previous maintainer and just continued as it was handled before: cut release, notify Googler to push image. I've previously been told that opening the release process is already in progress, so I for the time being decided to wait it out as the current approach wasn't giving us, as maintainers, too much pain.

How large is the image?

I'm not sure I understand the relevance, but my docker host is telling me 43.9MB.

Also, how do users know which Kubernetes releases a given release of kube-state-metrics will work with?

The README has a section on this, basically whatever client-go support matrix is.

I'll make sure we add a release process document, once we finish this discussion 🙂 .

andyxning · 2017-09-05T15:16:08Z

@bgrant0607 One more thing. heapster has the same release image not found problem in

Was the release team notified?

@brancz I don't think we have a release team.

What is the release process for kube-state-metrics?

What is a reference implementation of a normalized release process?

piosz · 2017-09-05T15:27:49Z

@andyxning There is a dedicated @kubernetes/sig-release-members team.

jdumars · 2017-09-05T15:45:12Z

@kubernetes/sig-release-members is not the release team, it's the SIG that sources many (but not all) release team members. https://github.com/orgs/kubernetes/teams/kubernetes-release-managers/members consists of the current release team.

piosz · 2017-09-05T15:57:55Z

@jdumars thanks for the info. Sorry for the confusion then.

bgrant0607 · 2017-09-06T17:52:46Z

@brancz An image so small could be posted to github:

https://help.github.com/articles/creating-releases/
https://help.github.com/articles/distributing-large-binaries/

andyxning · 2017-09-07T02:15:33Z

@bgrant0607 Github releases can be used to ship binaries.

Seems github does not support image registry protocol, i.e., docker pull github.com/kubernetes/kube-state-metrics. :)

bgrant0607 · 2017-09-07T05:15:09Z

@andyxning Bits are bits. It's true that Github doesn't support pulling images via a registry API.

Anyway, this isn't part of the official Kubernetes release and doesn't seem to be used in https://github.com/kubernetes/kubernetes/tree/master/cluster/addons. Other repos (e.g., kompose) also push their release artifacts to random places. We haven't standardized that yet.

So long as no tests run by prow pull this image (we've had a lot of failures caused by other registries in the past), I don't have a strong opinion right now.

piosz · 2017-09-07T10:03:04Z

/lgtm
As we have the other Kubernetes projects not pushed to google_containers and this is not a part of cluster/addons, I'm fine with changing the default registry, so that we are not the bottleneck here. The only concern is that now CoreOS is the bottleneck but let's see how this will work. Google will also build all versions and push them to google_containers registry, so please keep pinging us when the new version is ready.

brancz · 2017-09-07T10:10:30Z

Yes I would suggest that we just document both image registries and users are free to choose which they want, and we'll continue as we do today.

andyxning · 2017-09-07T11:52:09Z

@piosz @bgrant0607 Thanks for your suggestions on this.

please keep pinging us when the new version is ready.

Absolutely. we need to work together to make kube-state-metrics friendly to users. :)

…egistry_to_quay move default image registry to quay

k8s-ci-robot requested review from brancz, fabxc, loburm and piosz August 28, 2017 13:36

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2017

brancz reviewed Aug 28, 2017

View reviewed changes

move default image registry to quay

54e446b

andyxning force-pushed the move_default_image_registry_to_quay branch from 6f503ea to 54e446b Compare August 28, 2017 13:57

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2017

k8s-ci-robot assigned piosz Aug 28, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2017

brancz merged commit 7106e59 into kubernetes:master Sep 7, 2017

andyxning deleted the move_default_image_registry_to_quay branch September 7, 2017 11:50

brancz mentioned this pull request Jan 12, 2018

Provide binary for releases #85

Closed

while1malloc0 pushed a commit to while1malloc0/kube-state-metrics that referenced this pull request Jul 2, 2018

Merge pull request kubernetes#246 from andyxning/move_default_image_r…

905c6c6

…egistry_to_quay move default image registry to quay

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move default image registry to quay #246

move default image registry to quay #246

andyxning commented Aug 28, 2017 •

edited

Loading

brancz Aug 28, 2017

andyxning Aug 28, 2017

brancz Aug 28, 2017

andyxning Aug 28, 2017

brancz commented Aug 28, 2017

andyxning commented Aug 28, 2017 •

edited

Loading

piosz commented Aug 28, 2017

piosz commented Aug 28, 2017

piosz commented Aug 28, 2017

andyxning commented Sep 5, 2017

bgrant0607 commented Sep 5, 2017

brancz commented Sep 5, 2017 •

edited

Loading

andyxning commented Sep 5, 2017

piosz commented Sep 5, 2017

jdumars commented Sep 5, 2017

piosz commented Sep 5, 2017

bgrant0607 commented Sep 6, 2017

andyxning commented Sep 7, 2017 •

edited

Loading

bgrant0607 commented Sep 7, 2017

piosz commented Sep 7, 2017

brancz commented Sep 7, 2017

andyxning commented Sep 7, 2017 •

edited

Loading

move default image registry to quay #246

move default image registry to quay #246

Conversation

andyxning commented Aug 28, 2017 • edited Loading

brancz Aug 28, 2017

Choose a reason for hiding this comment

andyxning Aug 28, 2017

Choose a reason for hiding this comment

brancz Aug 28, 2017

Choose a reason for hiding this comment

andyxning Aug 28, 2017

Choose a reason for hiding this comment

brancz commented Aug 28, 2017

andyxning commented Aug 28, 2017 • edited Loading

piosz commented Aug 28, 2017

piosz commented Aug 28, 2017

piosz commented Aug 28, 2017

andyxning commented Sep 5, 2017

bgrant0607 commented Sep 5, 2017

brancz commented Sep 5, 2017 • edited Loading

andyxning commented Sep 5, 2017

piosz commented Sep 5, 2017

jdumars commented Sep 5, 2017

piosz commented Sep 5, 2017

bgrant0607 commented Sep 6, 2017

andyxning commented Sep 7, 2017 • edited Loading

bgrant0607 commented Sep 7, 2017

piosz commented Sep 7, 2017

brancz commented Sep 7, 2017

andyxning commented Sep 7, 2017 • edited Loading

andyxning commented Aug 28, 2017 •

edited

Loading

andyxning commented Aug 28, 2017 •

edited

Loading

brancz commented Sep 5, 2017 •

edited

Loading

andyxning commented Sep 7, 2017 •

edited

Loading

andyxning commented Sep 7, 2017 •

edited

Loading