feat: Generate OpenVX data for every release #2276
Conversation
Signed-off-by: Shafeeque E S <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-triage
|
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/S
shafeeqes
changed the title
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
Signed-off-by: Shafeeque E S <[email protected]>
Signed-off-by: Shafeeque E S <[email protected]>
.github/workflows/openvex.yml
Outdated
| uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 #v4.1.1 | ||
| - name: Set env | ||
| run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV | ||
| - uses: openvex/generate-vex@31b415924ea0d72ed5f2640f1dee59dea6c2770b |
There was a problem hiding this comment.
Can we pin this to the latest major as well?
There was a problem hiding this comment.
I see openvex has not tagged any release yet. Can we pin this to the latest c59881b41451d7ccba5c3b74cd195382b8971fcd commit then?
There was a problem hiding this comment.
I've raised an issue regarding releases: openvex/generate-vex#2.
There was a problem hiding this comment.
I see
openvexhas not tagged any release yet. Can we pin this to the latestc59881b41451d7ccba5c3b74cd195382b8971fcdcommit then?
Done.
| - name: Checkout code | ||
| uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 #v4.1.1 | ||
| - name: Set env | ||
| run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV |
There was a problem hiding this comment.
I'm afraid running openvex for all releases would generate unnecessary noise, since we generally only maintain the latest release branches. Can we restrict this to that only? cc @mrueg
There was a problem hiding this comment.
This is restricted only to a pushed tag. See line 7
There was a problem hiding this comment.
I think it might be better to run on release creation. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release
There was a problem hiding this comment.
+1, better to run on releases than tags.
.github/workflows/openvex.yml
Outdated
| # Refer: https://github.com/openvex/vexctl#operational-model | ||
| name: Run vexctl | ||
| with: | ||
| product: pkg:golang/kubernetes/kube-state-metrics@${{ env.RELEASE_VERSION }} |
There was a problem hiding this comment.
| product: pkg:golang/kubernetes/kube-state-metrics@${{ env.RELEASE_VERSION }} | |
| product: pkg:golang/k8s.io/kube-state-metrics/v2@${{ env.RELEASE_VERSION }} |
should this be the golang package name?
There was a problem hiding this comment.
There was a problem hiding this comment.
Why the v2? Is it not covered by the env?
There was a problem hiding this comment.
v2 is because it expects the full name of the golang package.
|
/lgtm Thanks! Right now this will output in Github Actions log so it should not block any release. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrueg, shafeeqes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
This PR adds a github workflow action to generate OpenVX data for every release.
#SecuritySlam
Which issue(s) this PR fixes:
Fixes part of #2274