-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: custommetrics: always extract the headers but only write it when we have metrics #2154
fix: custommetrics: always extract the headers but only write it when we have metrics #2154
Conversation
b28e2a1
to
64c05ae
Compare
Can you rename the commit message to be prefixed with: /assign @rexagod |
/triage accepted |
…them when we have metrics
64c05ae
to
e57a28a
Compare
i can confirm this PR fixed the first issue i mentioned at #2141 , thanks @chrischdi |
/lgtm /hold |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, mrueg, rexagod The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What this PR does / why we need it:
This PR removes the
hasResources
check to initialise all custom resource metric headers at startup.By doing this, there will be no delay in adding custom resource metrics on startup (because of trying to list resources and timeout after 10s and then doing the same for the next bunch of CRs)
Instead the metrics writer now checks if there are are metrics in the first element of the store for the given header and outputs depending on that.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Does not affect the cardinality.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2142